jenkins-bot has submitted this change and it was merged.
Change subject: Bring back parallax scroll of the lead image.
......................................................................
Bring back parallax scroll of the lead image.
Change-Id: Ib40da114acaa6ed024fdb425950219054f9e1b6b
---
M app/src/main/java/org/wikipedia/page/leadimages/ArticleHeaderView.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Mholloway: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/app/src/main/java/org/wikipedia/page/leadimages/ArticleHeaderView.java
b/app/src/main/java/org/wikipedia/page/leadimages/ArticleHeaderView.java
index e963a3e..f30913e 100644
--- a/app/src/main/java/org/wikipedia/page/leadimages/ArticleHeaderView.java
+++ b/app/src/main/java/org/wikipedia/page/leadimages/ArticleHeaderView.java
@@ -207,6 +207,7 @@
private void updateScroll(int scrollY) {
int offset = Math.min(getHeight(), scrollY);
+ image.getImage().setTranslationY(offset / 2);
setTranslationY(-offset);
}
--
To view, visit https://gerrit.wikimedia.org/r/306445
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib40da114acaa6ed024fdb425950219054f9e1b6b
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
