Ema has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/306665

Change subject: varnish: fix jemalloc chunk size config option name
......................................................................

varnish: fix jemalloc chunk size config option name

The option to tune virtual memory chunk size is lg_chunk, not
lg_chunk_size. The values we have been using so far have thus been
ignored, and the default value for lg_chunk (2^22=4M) has been used.

Set the chunk size to 512K (2^19) on cache_text, and 1M (2^20) on the
others. We can re-experiment with lower values later on.

Bug: T135384
Change-Id: Ia9bf5bd8efc0dc38433f2933ab5214cfc79b0d8b
---
M modules/role/manifests/cache/maps.pp
M modules/role/manifests/cache/misc.pp
M modules/role/manifests/cache/text.pp
M modules/role/manifests/cache/upload.pp
4 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/65/306665/1

diff --git a/modules/role/manifests/cache/maps.pp 
b/modules/role/manifests/cache/maps.pp
index 062925f..4af7db3 100644
--- a/modules/role/manifests/cache/maps.pp
+++ b/modules/role/manifests/cache/maps.pp
@@ -54,7 +54,7 @@
 
     role::cache::instances { 'maps':
         fe_mem_gb        => ceiling(0.4 * $::memorysize_mb / 1024.0),
-        fe_jemalloc_conf => 'lg_dirty_mult:8,lg_chunk_size:17',
+        fe_jemalloc_conf => 'lg_dirty_mult:8,lg_chunk:20',
         runtime_params   => ['default_ttl=86400'],
         app_directors    => $app_directors,
         fe_vcl_config    => $common_vcl_config,
diff --git a/modules/role/manifests/cache/misc.pp 
b/modules/role/manifests/cache/misc.pp
index 063e9c4..97d6d6c 100644
--- a/modules/role/manifests/cache/misc.pp
+++ b/modules/role/manifests/cache/misc.pp
@@ -292,7 +292,7 @@
 
     role::cache::instances { 'misc':
         fe_mem_gb        => ceiling(0.4 * $::memorysize_mb / 1024.0),
-        fe_jemalloc_conf => 'lg_dirty_mult:8,lg_chunk_size:17',
+        fe_jemalloc_conf => 'lg_dirty_mult:8,lg_chunk:20',
         runtime_params   => ['default_ttl=3600'],
         app_directors    => $app_directors,
         fe_vcl_config    => $fe_vcl_config,
diff --git a/modules/role/manifests/cache/text.pp 
b/modules/role/manifests/cache/text.pp
index 9c89fae..a9756d4 100644
--- a/modules/role/manifests/cache/text.pp
+++ b/modules/role/manifests/cache/text.pp
@@ -115,7 +115,7 @@
 
     role::cache::instances { 'text':
         fe_mem_gb        => ceiling(0.4 * $::memorysize_mb / 1024.0),
-        fe_jemalloc_conf => 'lg_dirty_mult:8,lg_chunk_size:16',
+        fe_jemalloc_conf => 'lg_dirty_mult:8,lg_chunk:19',
         runtime_params   => ['default_ttl=2592000'],
         app_directors    => $app_directors,
         fe_vcl_config    => $fe_vcl_config,
diff --git a/modules/role/manifests/cache/upload.pp 
b/modules/role/manifests/cache/upload.pp
index 71d1a20..dc9a1a4 100644
--- a/modules/role/manifests/cache/upload.pp
+++ b/modules/role/manifests/cache/upload.pp
@@ -105,7 +105,7 @@
 
     role::cache::instances { 'upload':
         fe_mem_gb        => ceiling(0.4 * $::memorysize_mb / 1024.0),
-        fe_jemalloc_conf => 'lg_dirty_mult:8,lg_chunk_size:17',
+        fe_jemalloc_conf => 'lg_dirty_mult:8,lg_chunk:20',
         runtime_params   => ['default_ttl=604800'], # default_ttl=7d
         app_directors    => $app_directors,
         fe_vcl_config    => $fe_vcl_config,

-- 
To view, visit https://gerrit.wikimedia.org/r/306665
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9bf5bd8efc0dc38433f2933ab5214cfc79b0d8b
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ema <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to