Martineznovo has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/306667

Change subject: Turn $wgRunJobsAsync off by default
......................................................................

Turn $wgRunJobsAsync off by default

The current situation doesn't work in all installations and has being worse
since MediaWiki 1.27. Default settings should be safe in all installations,
and $wgRunJobsAsync wasn't one of them.

Bug: T142751
Change-Id: I8daa38534a0e925a75ba2fb47e3e299f1baee4b1
---
M RELEASE-NOTES-1.28
M includes/DefaultSettings.php
2 files changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/67/306667/1

diff --git a/RELEASE-NOTES-1.28 b/RELEASE-NOTES-1.28
index 92ac869..c6e0228 100644
--- a/RELEASE-NOTES-1.28
+++ b/RELEASE-NOTES-1.28
@@ -26,6 +26,8 @@
   https://www.mediawiki.org/beacon with basic information about the local
   MediaWiki installation.  This data includes, for example, the type of system,
   PHP version, and chosen database backend. This behavior is off by default.
+* $wgRunJobsAsync is now false by default (T142751). This change only affects
+  wikis with $wgJobRunRate > 0.
 
 === New features in 1.28 ===
 * User::isBot() method for checking if an account is a bot role account.
diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index f1afc4c..18eab62 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -8045,10 +8045,7 @@
  *
  * @since 1.23
  */
-$wgRunJobsAsync = (
-       !function_exists( 'register_postsend_function' ) &&
-       !function_exists( 'fastcgi_finish_request' )
-);
+$wgRunJobsAsync = false;
 
 /**
  * Number of rows to update per job

-- 
To view, visit https://gerrit.wikimedia.org/r/306667
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8daa38534a0e925a75ba2fb47e3e299f1baee4b1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Martineznovo <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to