Filippo Giunchedi has submitted this change and it was merged.
Change subject: Git::clone: rename $default_source to $source and add github
......................................................................
Git::clone: rename $default_source to $source and add github
Change-Id: I6c723973e220e46b87595013f6551ecf3e2887ff
---
M modules/git/manifests/clone.pp
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Filippo Giunchedi: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/git/manifests/clone.pp b/modules/git/manifests/clone.pp
index d41be3b..c4a7dab 100644
--- a/modules/git/manifests/clone.pp
+++ b/modules/git/manifests/clone.pp
@@ -27,8 +27,8 @@
# $+mode+:: Permission mode of $directory, default: 2755 if shared, 0755
otherwise
# $+ssh+:: SSH command/wrapper to use when checking out, default: ''
# $+timeout+:: Time out in seconds for the exec command, default: 300
-# $+default_source+:: Where to request the repo from, if $origin isn't
specified
-# default to 'gerrit', 'phabricator' also accepted
+# $+source+:: Where to request the repo from, if $origin isn't specified
+# 'phabricator', 'github' and 'gerrit' accepted, default is
'gerrit'
#
# === Example usage
#
@@ -60,10 +60,11 @@
$recurse_submodules=false,
$umask=undef,
$mode=undef,
- $default_source='gerrit') {
+ $source='gerrit') {
- $default_url_format = $default_source ? {
+ $default_url_format = $source ? {
'phabricator' => 'https://phabricator.wikimedia.org/diffusion/%.git',
+ 'github' => 'https://github.com/wikimedia/%s.git',
'gerrit' => 'https://gerrit.wikimedia.org/r/p/%s.git',
default => 'https://gerrit.wikimedia.org/r/p/%s.git',
}
--
To view, visit https://gerrit.wikimedia.org/r/301484
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c723973e220e46b87595013f6551ecf3e2887ff
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Chad <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Filippo Giunchedi <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
