Niedzielski has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/306815

Change subject: Hygiene: move Gradle Checkstyle to separate script
......................................................................

Hygiene: move Gradle Checkstyle to separate script

Change-Id: I95455e19657ed5d6031b082c003c86c32b68b641
---
M app/build.gradle
A config/checkstyle.gradle
M config/quality.gradle
3 files changed, 21 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/15/306815/1

diff --git a/app/build.gradle b/app/build.gradle
index b71277d..53eb337 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -3,6 +3,7 @@
 apply plugin: 'com.neenbedankt.android-apt'
 
 apply from: '../config/test.gradle'
+apply from: '../config/checkstyle.gradle'
 apply from: '../config/quality.gradle'
 
 import com.android.build.gradle.internal.dsl.ProductFlavor
diff --git a/config/checkstyle.gradle b/config/checkstyle.gradle
new file mode 100644
index 0000000..0779019
--- /dev/null
+++ b/config/checkstyle.gradle
@@ -0,0 +1,20 @@
+// see also 
http://stackoverflow.com/questions/17050654/get-android-gradle-plugin-checkstyle-working-together-command-line-usage
+apply plugin: 'checkstyle'
+
+check.dependsOn 'checkstyle'
+
+checkstyle {
+    configFile = file('../config/checkstyle.xml')
+    toolVersion = '6.11.2'
+}
+
+task checkstyle(type: Checkstyle) {
+    source 'src/main/java'
+    source 'src/androidTest/java'
+    source 'src/test/java'
+    source 'src/testlib/java'
+    include '**/*.java'
+    exclude '**/gen/**'
+
+    classpath = configurations.compile
+}
\ No newline at end of file
diff --git a/config/quality.gradle b/config/quality.gradle
index 976abb4..04e3bb2 100644
--- a/config/quality.gradle
+++ b/config/quality.gradle
@@ -1,25 +1,4 @@
-// see also 
http://stackoverflow.com/questions/17050654/get-android-gradle-plugin-checkstyle-working-together-command-line-usage
-
-apply plugin: 'checkstyle'
 apply plugin: 'spoon'
-
-check.dependsOn 'checkstyle'
-
-checkstyle {
-    configFile = file('../config/checkstyle.xml')
-    toolVersion = '6.11.2'
-}
-
-task checkstyle(type: Checkstyle) {
-    source 'src/main/java'
-    source 'src/androidTest/java'
-    source 'src/test/java'
-    source 'src/testlib/java'
-    include '**/*.java'
-    exclude '**/gen/**'
-
-    classpath = configurations.compile
-}
 
 spoon {
     adbTimeout = 600

-- 
To view, visit https://gerrit.wikimedia.org/r/306815
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I95455e19657ed5d6031b082c003c86c32b68b641
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to