jenkins-bot has submitted this change and it was merged.
Change subject: Add some more info to failed incoming link count jobs
......................................................................
Add some more info to failed incoming link count jobs
These jobs log regular failures to logstash, but on checking the
reported id's all the pages seem to exist in the index. I'm doubtful
that the problem is sending to wrong index, but it's simple enough to
add the info the log and find out.
Change-Id: I62c79e1e09bb6a318642228acea8aad47917fc3c
---
M includes/DataSender.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Smalyshev: Looks good to me, approved
Cindy-the-browser-test-bot: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/includes/DataSender.php b/includes/DataSender.php
index d14510b..c7f026b 100644
--- a/includes/DataSender.php
+++ b/includes/DataSender.php
@@ -192,10 +192,10 @@
$responseSet = $bulk->send();
} catch ( ResponseException $e ) {
$justDocumentMissing =
$this->bulkResponseExceptionIsJustDocumentMissing( $e,
- function( $docId ) use ( $e ) {
+ function( $docId ) use ( $e, $indexType ) {
$this->log->info(
"Updating a page that doesn't
yet exist in Elasticsearch: {docId}",
- [ 'docId' => $docId ]
+ [ 'docId' => $docId,
'indexType' => $indexType ]
);
}
);
--
To view, visit https://gerrit.wikimedia.org/r/307328
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62c79e1e09bb6a318642228acea8aad47917fc3c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: Cindy-the-browser-test-bot <[email protected]>
Gerrit-Reviewer: DCausse <[email protected]>
Gerrit-Reviewer: Gehel <[email protected]>
Gerrit-Reviewer: Manybubbles <[email protected]>
Gerrit-Reviewer: Smalyshev <[email protected]>
Gerrit-Reviewer: Storedbox <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
