Ljonka has submitted this change and it was merged.
Change subject: Review: using extension.json
......................................................................
Review: using extension.json
Change-Id: I96625ed2a13206a046c9e91eb74c45855ed89b28
---
M Review/Review.class.php
M Review/Review.setup.php
A Review/extension.json
3 files changed, 98 insertions(+), 103 deletions(-)
Approvals:
Ljonka: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/Review/Review.class.php b/Review/Review.class.php
index 3f77767..224fb81 100644
--- a/Review/Review.class.php
+++ b/Review/Review.class.php
@@ -45,31 +45,6 @@
* @var LogPage Logger object that writes to MW log
*/
protected $oLogger;
-
- /**
- * Constructor of Review class
- */
- public function __construct() {
-
- // Base settings
- $this->mExtensionFile = __FILE__;
- $this->mExtensionType = EXTTYPE::OTHER;
//SPECIALPAGE/OTHER/VARIABLE/PARSERHOOK
- $this->mInfo = array(
- EXTINFO::NAME => 'Review',
- EXTINFO::DESCRIPTION => 'bs-review-desc',
- EXTINFO::AUTHOR => 'Markus Glaser',
- EXTINFO::VERSION => 'default',
- EXTINFO::STATUS => 'default',
- EXTINFO::PACKAGE => 'default',
- EXTINFO::URL =>
'https://help.bluespice.com/index.php/Review',
- EXTINFO::DEPS => array(
- 'bluespice' => '2.23.3',
- 'StateBar' => '2.22.0'
- )
- );
- $this->mExtensionKey = 'MW::Review';
- }
-
/**
* Initialization of Review extension
*/
diff --git a/Review/Review.setup.php b/Review/Review.setup.php
index 21702c6..1d04065 100644
--- a/Review/Review.setup.php
+++ b/Review/Review.setup.php
@@ -1,79 +1,2 @@
<?php
-
-BsExtensionManager::registerExtension( 'Review',
BsRUNLEVEL::FULL|BsRUNLEVEL::REMOTE );
-
-$wgMessagesDirs['Review'] = __DIR__ . '/i18n';
-
-$wgExtensionMessagesFiles['ReviewAlias'] = __DIR__ .
'/languages/SpecialReview.alias.php';
-
-$aResourceModuleTemplate = array(
- 'localBasePath' => __DIR__ . '/resources',
- 'remoteExtPath' => 'BlueSpiceExtensions/Review/resources'
-);
-
-$wgResourceModules['ext.bluespice.review.styles'] = array(
- 'styles' => 'bluespice.review.css',
- 'position' => 'top'
-) + $aResourceModuleTemplate;
-
-$wgResourceModules['ext.bluespice.review'] = array(
- 'scripts' => 'bluespice.review.js',
- 'dependencies' => array(
- 'ext.bluespice',
- ),
- 'messages' => array(
- 'bs-review-review',
- 'bs-review-btnmoveup',
- 'bs-review-btnmovedown',
- 'bs-review-colstatus',
- 'bs-review-colreviewer',
- 'bs-review-colcomment',
- 'bs-review-lblstartdate',
- 'bs-review-lblenddate',
- 'bs-review-titleaddreviewer',
- 'bs-review-labelcomment',
- 'bs-review-confirm-delete-step',
- 'bs-review-confirm-delete-review'
- )
-) + $aResourceModuleTemplate;
-
-$wgResourceModules['ext.bluespice.review.overview'] = array(
- 'scripts' => 'bluespice.review.overview.js',
- 'dependencies' => array (
- 'ext.bluespice.extjs',
- 'ext.bluespice.review',
- 'mediawiki.Title'
- ),
- 'messages' => array(
- 'bs-review-header-page-title',
- 'bs-review-header-owner-name',
- 'bs-review-header-assessors',
- 'bs-review-header-accepted-text',
- 'bs-review-header-startdate',
- 'bs-review-header-enddate'
- )
-) + $aResourceModuleTemplate;
-
-unset( $aResourceModuleTemplate);
-
-$wgAutoloadClasses['Review'] = __DIR__ . '/Review.class.php';
-$wgAutoloadClasses['SpecialReview'] = __DIR__ .
'/includes/specials/SpecialReview.class.php';
-$wgAutoloadClasses['BsReviewProcess'] = __DIR__ .
'/includes/ReviewProcess.class.php';
-$wgAutoloadClasses['BsReviewProcessStep'] = __DIR__ .
'/includes/ReviewProcessStep.class.php';
-$wgAutoloadClasses['ReviewFormatter'] = __DIR__ .
'/includes/ReviewFormatter.class.php';
-$wgAutoloadClasses['BSApiReviewPossibleReviewersStore'] = __DIR__ .
'/includes/api/BSApiReviewPossibleReviewersStore.php';
-$wgAutoloadClasses['BSApiReviewOverviewStore'] = __DIR__ .
'/includes/api/BSApiReviewOverviewStore.php';
-$wgAutoloadClasses['BSApiReviewTasks'] = __DIR__ .
'/includes/api/BSApiReviewTasks.php';
-
-$wgAutoloadClasses['ViewStateBarBodyElementReview'] = __DIR__ .
'/views/view.StateBarBodyElementReview.php';
-
-$wgSpecialPages['Review'] = 'SpecialReview';
-
-$wgAPIModules['bs-reviewpossiblereviewers-store'] =
'BSApiReviewPossibleReviewersStore';
-$wgAPIModules['bs-reviewoverview-store'] = 'BSApiReviewOverviewStore';
-$wgAPIModules['bs-review-tasks'] = 'BSApiReviewTasks';
-
-$wgLogTypes[] = 'bs-review';
-$wgFilterLogTypes['bs-review'] = true;
-
-$wgHooks['LoadExtensionSchemaUpdates'][] = 'Review::getSchemaUpdates';
+wfLoadExtension( 'BlueSpiceExtensions/Review' );
\ No newline at end of file
diff --git a/Review/extension.json b/Review/extension.json
new file mode 100644
index 0000000..2ffb8e4
--- /dev/null
+++ b/Review/extension.json
@@ -0,0 +1,97 @@
+{
+ "name": "Review",
+ "version": "2.27.0",
+ "url": "https://help.bluespice.com/index.php/Review";,
+ "author": "Markus Glaser",
+ "descriptionmsg": "bs-review-desc",
+ "type": "bluespice",
+ "bsgExtensions": {
+ "Review": {
+ "className": "Review",
+ "extPath": "/BlueSpiceExtensions/Review"
+ }
+ },
+ "SpecialPages": {
+ "Review": "SpecialReview"
+ },
+ "LogTypes": [
+ "bs-review"
+ ],
+ "FilterLogTypes": {
+ "bs-review": true
+ },
+ "APIModules": {
+ "bs-reviewpossiblereviewers-store":
"BSApiReviewPossibleReviewersStore",
+ "bs-reviewoverview-store": "BSApiReviewOverviewStore",
+ "bs-review-tasks": "BSApiReviewTasks"
+ },
+ "MessagesDirs": {
+ "Review": [
+ "i18n"
+ ]
+ },
+ "ExtensionMessagesFiles": {
+ "ReviewAlias": "languages/SpecialReview.alias.php"
+ },
+ "AutoloadClasses": {
+ "Review": "Review.class.php",
+ "SpecialReview": "includes/specials/SpecialReview.class.php",
+ "BsReviewProcess": "includes/ReviewProcess.class.php",
+ "BsReviewProcessStep": "includes/ReviewProcessStep.class.php",
+ "ReviewFormatter": "includes/ReviewFormatter.class.php",
+ "BSApiReviewPossibleReviewersStore":
"includes/api/BSApiReviewPossibleReviewersStore.php",
+ "BSApiReviewOverviewStore":
"includes/api/BSApiReviewOverviewStore.php",
+ "BSApiReviewTasks": "includes/api/BSApiReviewTasks.php",
+ "ViewStateBarBodyElementReview":
"views/view.StateBarBodyElementReview.php"
+ },
+ "ResourceModules": {
+ "ext.bluespice.review.styles": {
+ "styles": "bluespice.review.css",
+ "position": "top"
+ },
+ "ext.bluespice.review": {
+ "scripts": "bluespice.review.js",
+ "dependencies": [
+ "ext.bluespice"
+ ],
+ "messages": [
+ "bs-review-review",
+ "bs-review-btnmoveup",
+ "bs-review-btnmovedown",
+ "bs-review-colstatus",
+ "bs-review-colreviewer",
+ "bs-review-colcomment",
+ "bs-review-lblstartdate",
+ "bs-review-lblenddate",
+ "bs-review-titleaddreviewer",
+ "bs-review-labelcomment",
+ "bs-review-confirm-delete-step",
+ "bs-review-confirm-delete-review"
+ ]
+ },
+ "ext.bluespice.review.overview": {
+ "scripts": "bluespice.review.overview.js",
+ "dependencies": [
+ "ext.bluespice.extjs",
+ "ext.bluespice.review",
+ "mediawiki.Title"
+ ],
+ "messages": [
+ "bs-review-header-page-title",
+ "bs-review-header-owner-name",
+ "bs-review-header-assessors",
+ "bs-review-header-accepted-text",
+ "bs-review-header-startdate",
+ "bs-review-header-enddate"
+ ]
+ }
+ },
+ "ResourceFileModulePaths": {
+ "localBasePath": "resources",
+ "remoteExtPath": "BlueSpiceExtensions/Review/resources"
+ },
+ "Hooks": {
+ "LoadExtensionSchemaUpdates": "Review::getSchemaUpdates"
+ },
+ "manifest_version": 1
+}
--
To view, visit https://gerrit.wikimedia.org/r/305245
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96625ed2a13206a046c9e91eb74c45855ed89b28
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Gerharddiller85 <gerharddil...@icloud.com>
Gerrit-Reviewer: Dvogel hallowelt <daniel.vo...@hallowelt.com>
Gerrit-Reviewer: Ljonka <l.verhovs...@gmail.com>
Gerrit-Reviewer: Mglaser <gla...@hallowelt.biz>
Gerrit-Reviewer: Pwirth <wi...@hallowelt.biz>
Gerrit-Reviewer: Robert Vogel <vo...@hallowelt.biz>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
