jenkins-bot has submitted this change and it was merged. Change subject: Remove unused attribute mIsAjaxRequest ......................................................................
Remove unused attribute mIsAjaxRequest The attribute mIsAjaxRequest is unused since 4b4a6308. Change-Id: Ief01459527f04a13eb4db7e2d099188fc5c5504e --- M ApiCategoryTree.php M CategoryTreeFunctions.php 2 files changed, 3 insertions(+), 7 deletions(-) Approvals: Glaisher: Looks good to me, approved jenkins-bot: Verified diff --git a/ApiCategoryTree.php b/ApiCategoryTree.php index e824968..4a417cf 100644 --- a/ApiCategoryTree.php +++ b/ApiCategoryTree.php @@ -14,7 +14,7 @@ } $depth = isset( $options['depth'] ) ? (int)$options['depth'] : 1; - $ct = new CategoryTree( $options, true ); + $ct = new CategoryTree( $options ); $depth = CategoryTree::capDepth( $ct->getOption( 'mode' ), $depth ); $title = CategoryTree::makeTitle( $params['category'] ); $config = $this->getConfig(); @@ -114,4 +114,4 @@ public function isInternal() { return true; } -} \ No newline at end of file +} diff --git a/CategoryTreeFunctions.php b/CategoryTreeFunctions.php index 5e2198a..b6f7696 100644 --- a/CategoryTreeFunctions.php +++ b/CategoryTreeFunctions.php @@ -16,17 +16,13 @@ } class CategoryTree { - public $mIsAjaxRequest = false; public $mOptions = array(); /** * @param $options array - * @param $ajax bool */ - function __construct( $options, $ajax = false ) { + function __construct( $options ) { global $wgCategoryTreeDefaultOptions; - - $this->mIsAjaxRequest = $ajax; # ensure default values and order of options. Order may become important, it may influence the cache key! foreach ( $wgCategoryTreeDefaultOptions as $option => $default ) { -- To view, visit https://gerrit.wikimedia.org/r/307240 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief01459527f04a13eb4db7e2d099188fc5c5504e Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/CategoryTree Gerrit-Branch: master Gerrit-Owner: Fomafix <foma...@googlemail.com> Gerrit-Reviewer: Glaisher <glaisher.w...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits