Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307901
Change subject: DesktopWikitextArticleTarget#switchToVisualEditor: Use correct
revision ID property
......................................................................
DesktopWikitextArticleTarget#switchToVisualEditor: Use correct revision ID
property
So we ensure we send the actual revision ID, not potentially undefined, to the
method. If we send undefined, it'll give us an etag for revision number 0...
And that will cause issues when we later attempt (in a future editor switch) to
pass an etag for revision 0 along with the correct revision.
Bug: T143920
Change-Id: I0c27956abdd26ae4f5f1b91010a5eab8ee0354ab
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/01/307901/1
diff --git
a/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js
index 1eb0839..cf6b5ba 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js
@@ -85,7 +85,7 @@
dataPromise = mw.libs.ve.targetLoader.requestParsoidData(
this.pageName,
- this.requestedRevId,
+ this.revid,
this.constructor.name,
this.edited,
this.getWikitextFromDocument( this.getSurface().getDom() )
--
To view, visit https://gerrit.wikimedia.org/r/307901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c27956abdd26ae4f5f1b91010a5eab8ee0354ab
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <a...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
