Tobias Gritschacher has submitted this change and it was merged.
Change subject: Attempt to make reference test more stable
......................................................................
Attempt to make reference test more stable
Bug: T144190
Change-Id: I2fc64e5a251d1520d9cc372caa468717fc99059b
---
M tests/browser/features/step_definitions/reference_steps.rb
M tests/browser/features/support/modules/reference_module.rb
2 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/step_definitions/reference_steps.rb
b/tests/browser/features/step_definitions/reference_steps.rb
index 06df540..f5c5da2 100644
--- a/tests/browser/features/step_definitions/reference_steps.rb
+++ b/tests/browser/features/step_definitions/reference_steps.rb
@@ -24,7 +24,10 @@
When /^I add the following reference snaks:$/ do |table|
step 'I click the statement edit button'
- on(ItemPage).add_reference_snaks(table.raw, @properties)
+ on(ItemPage) do |page|
+ page.ajax_wait
+ page.add_reference_snaks(table.raw, @properties)
+ end
step 'I click the statement save button'
end
diff --git a/tests/browser/features/support/modules/reference_module.rb
b/tests/browser/features/support/modules/reference_module.rb
index 8a1d39a..532c45a 100644
--- a/tests/browser/features/support/modules/reference_module.rb
+++ b/tests/browser/features/support/modules/reference_module.rb
@@ -59,6 +59,7 @@
end
property_handle = snak[0]
value = snak[1]
+ ajax_wait
snak_entity_selector_input(index).when_visible.clear
snak_entity_selector_input(index).send_keys
properties[property_handle]['label']
ajax_wait
--
To view, visit https://gerrit.wikimedia.org/r/307771
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fc64e5a251d1520d9cc372caa468717fc99059b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
