Mooeypoo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308001
Change subject: Hide xwiki widget separator when widget is expanded
......................................................................
Hide xwiki widget separator when widget is expanded
Bug: T142260
Change-Id: I24fbd6bd2eba3c7b2d16cb1e46130cfd4a981fb3
---
M modules/styles/mw.echo.ui.CrossWikiNotificationItemWidget.less
M modules/ui/mw.echo.ui.CrossWikiNotificationItemWidget.js
2 files changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/01/308001/1
diff --git a/modules/styles/mw.echo.ui.CrossWikiNotificationItemWidget.less
b/modules/styles/mw.echo.ui.CrossWikiNotificationItemWidget.less
index 2d930ca..87e5dc9 100644
--- a/modules/styles/mw.echo.ui.CrossWikiNotificationItemWidget.less
+++ b/modules/styles/mw.echo.ui.CrossWikiNotificationItemWidget.less
@@ -44,6 +44,14 @@
bottom: 0.4em;
width: 100%;
border-bottom: 1px #eeeeee solid;
+
+ .mw-echo-ui-crossWikiNotificationItemWidget-expanded & {
+ display: none;
+ }
+ }
+
+ &-expanded &-separator {
+ display: none;
}
&-group {
diff --git a/modules/ui/mw.echo.ui.CrossWikiNotificationItemWidget.js
b/modules/ui/mw.echo.ui.CrossWikiNotificationItemWidget.js
index 2322db7..42a95f6 100644
--- a/modules/ui/mw.echo.ui.CrossWikiNotificationItemWidget.js
+++ b/modules/ui/mw.echo.ui.CrossWikiNotificationItemWidget.js
@@ -315,7 +315,9 @@
mw.echo.ui.CrossWikiNotificationItemWidget.prototype.toggleExpanded =
function ( show ) {
this.expanded = show !== undefined ? !!show : !this.expanded;
- if ( show ) {
+ this.$element.toggleClass(
'mw-echo-ui-crossWikiNotificationItemWidget-expanded', this.expanded );
+
+ if ( this.expanded ) {
this.getList().$element.slideDown();
} else {
this.getList().$element.slideUp();
--
To view, visit https://gerrit.wikimedia.org/r/308001
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I24fbd6bd2eba3c7b2d16cb1e46130cfd4a981fb3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
