BryanDavis has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308087
Change subject: Use normal messages rather than notices for help
......................................................................
Use normal messages rather than notices for help
This just randomly bugs me. I know that using notice for this is more
proper to the IRC protocol spec, but all the clients I use actually ping
on all in-channel notices.
Change-Id: I4a699dd1bece54f8a1b5c347fd4034934aefca92
---
M jouncebot.py
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/bots/jouncebot
refs/changes/87/308087/1
diff --git a/jouncebot.py b/jouncebot.py
index 063ce09..f1f5ab8 100755
--- a/jouncebot.py
+++ b/jouncebot.py
@@ -132,7 +132,7 @@
def do_command_help(self, conn, event, cmd, source, nickmask):
"""Prints the list of all commands known to the server"""
- self.multiline_notice(
+ self.multiline(
conn,
source,
"""
@@ -142,7 +142,7 @@
\x02Available commands:\x02"""
)
for cmd in sorted(self.brain):
- self.multiline_notice(conn, source, " %-7s %s" % (
+ self.multiline(conn, source, " %-7s %s" % (
cmd.upper(), self.brain[cmd].__doc__))
def do_command_die(self, conn, event, cmd, nick, nickmask):
@@ -194,7 +194,7 @@
self.connection.privmsg(
self.channel, msg.format(owners=owners, event=event))
- def multiline_notice(self, conn, nick, text):
+ def multiline(self, conn, nick, text):
lines = text.expandtabs().splitlines()
indent = sys.maxint
if lines[1:]:
@@ -203,12 +203,12 @@
indent = min(indent, len(lines[1]) - len(stripped))
if lines[0] == '':
del lines[0]
- conn.notice(nick, lines[0][indent:])
+ conn.privmsg(nick, lines[0][indent:])
else:
- conn.notice(nick, lines[0])
+ conn.privmsg(nick, lines[0])
for line in lines[1:]:
- conn.notice(nick, line[indent:])
+ conn.privmsg(nick, line[indent:])
if __name__ == "__main__":
--
To view, visit https://gerrit.wikimedia.org/r/308087
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a699dd1bece54f8a1b5c347fd4034934aefca92
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/bots/jouncebot
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
