jenkins-bot has submitted this change and it was merged. Change subject: Hygiene: rename NavTabViewPagerAdapter ......................................................................
Hygiene: rename NavTabViewPagerAdapter Rename NavTabViewPagerAdapter to NavTabFragmentPagerAdapter. NTFPA returns Fragments and shouldn't be confused with NavTabViews which are buttons. Change-Id: I7e36da6ba12aa109232f79050451b7f90cd412ea --- M app/src/main/java/org/wikipedia/MainFragment.java R app/src/main/java/org/wikipedia/navtab/NavTabFragmentPagerAdapter.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Dbrant: Looks good to me, approved jenkins-bot: Verified diff --git a/app/src/main/java/org/wikipedia/MainFragment.java b/app/src/main/java/org/wikipedia/MainFragment.java index 1c522fc..ed1ee8e 100644 --- a/app/src/main/java/org/wikipedia/MainFragment.java +++ b/app/src/main/java/org/wikipedia/MainFragment.java @@ -30,7 +30,7 @@ import org.wikipedia.login.LoginActivity; import org.wikipedia.navtab.NavTab; import org.wikipedia.nearby.NearbyFragment; -import org.wikipedia.navtab.NavTabViewPagerAdapter; +import org.wikipedia.navtab.NavTabFragmentPagerAdapter; import org.wikipedia.page.ExclusiveBottomSheetPresenter; import org.wikipedia.page.PageActivity; import org.wikipedia.page.PageTitle; @@ -82,7 +82,7 @@ View view = inflater.inflate(R.layout.fragment_main, container, false); unbinder = ButterKnife.bind(this, view); - viewPager.setAdapter(new NavTabViewPagerAdapter(getChildFragmentManager())); + viewPager.setAdapter(new NavTabFragmentPagerAdapter(getChildFragmentManager())); tabLayout.setupWithViewPager(viewPager); bottomSheetPresenter = new ExclusiveBottomSheetPresenter(getChildFragmentManager()); diff --git a/app/src/main/java/org/wikipedia/navtab/NavTabViewPagerAdapter.java b/app/src/main/java/org/wikipedia/navtab/NavTabFragmentPagerAdapter.java similarity index 73% rename from app/src/main/java/org/wikipedia/navtab/NavTabViewPagerAdapter.java rename to app/src/main/java/org/wikipedia/navtab/NavTabFragmentPagerAdapter.java index f780501..7f3d52f 100644 --- a/app/src/main/java/org/wikipedia/navtab/NavTabViewPagerAdapter.java +++ b/app/src/main/java/org/wikipedia/navtab/NavTabFragmentPagerAdapter.java @@ -4,8 +4,8 @@ import android.support.v4.app.FragmentManager; import android.support.v4.app.FragmentStatePagerAdapter; -public class NavTabViewPagerAdapter extends FragmentStatePagerAdapter { - public NavTabViewPagerAdapter(FragmentManager mgr) { +public class NavTabFragmentPagerAdapter extends FragmentStatePagerAdapter { + public NavTabFragmentPagerAdapter(FragmentManager mgr) { super(mgr); } -- To view, visit https://gerrit.wikimedia.org/r/308654 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e36da6ba12aa109232f79050451b7f90cd412ea Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org> Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits