Hello jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/47326
to review the following change.
Change subject: Bugfix and tidy-up
......................................................................
Bugfix and tidy-up
Allow the configuration file to be optional for test mode
Tidy-up the hipchat notifier module
- Require a valid hipchat authtoken
Ignore temporary vi/vim files in .gitignore
Add extra debugging output
- write out cache file to enable easy removal to force upload
- clearly notify that no changes are seen so uploading not occurring
Change-Id: Ia418704b76090e284e0b801609f2f05bfa06b9ae
Reviewed-on: https://review.openstack.org/20380
Reviewed-by: Jeremy Stanley <[email protected]>
Reviewed-by: Khai Do <[email protected]>
Reviewed-by: Clark Boylan <[email protected]>
Approved: James E. Blair <[email protected]>
Reviewed-by: James E. Blair <[email protected]>
Tested-by: Jenkins
---
M .gitignore
M jenkins_jobs/builder.py
M jenkins_jobs/cmd.py
M jenkins_jobs/modules/hipchat_notif.py
4 files changed, 25 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder
refs/changes/26/47326/1
--
To view, visit https://gerrit.wikimedia.org/r/47326
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia418704b76090e284e0b801609f2f05bfa06b9ae
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
