jenkins-bot has submitted this change and it was merged. Change subject: Add UUID column & engine-specific table options ......................................................................
Add UUID column & engine-specific table options - Engine-specific defaults. For MySQL: InnoDB & UTF-8. - Store UUIDs as CHAR(32). Our analysts do a lot of work directly in the database so I chose to optimize for legibility and not store as binary CHAR(16). - Use Unicode type for strings. - Adds a unit tests. I need to think about how to split it up; I don't like that it asserts too much. I miss New York City a lot. :-( Change-Id: I74b6b01ea84515e5cf19038cfe5aba7e0a061a5a --- M server/eventlogging/jrm.py M server/tests/test_jrm.py 2 files changed, 43 insertions(+), 21 deletions(-) Approvals: Ori.livneh: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/47327 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74b6b01ea84515e5cf19038cfe5aba7e0a061a5a Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/EventLogging Gerrit-Branch: master Gerrit-Owner: Ori.livneh <[email protected]> Gerrit-Reviewer: Ori.livneh <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
