Fomafix has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308762
Change subject: Move hook 'wikipage.diff' from startup.js to mediawiki.diff.js
......................................................................
Move hook 'wikipage.diff' from startup.js to mediawiki.diff.js
The module 'mediawiki.diff' is loaded when there is a diff on the page.
The hook 'wikipage.diff' can fired from that module, too.
Change-Id: I92d6a8fbced64fd44edc394de0969e910e1ddd34
---
M resources/src/mediawiki/mediawiki.diff.js
M resources/src/mediawiki/page/startup.js
2 files changed, 13 insertions(+), 15 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/62/308762/1
diff --git a/resources/src/mediawiki/mediawiki.diff.js
b/resources/src/mediawiki/mediawiki.diff.js
index f648c8e..74d4cd4 100644
--- a/resources/src/mediawiki/mediawiki.diff.js
+++ b/resources/src/mediawiki/mediawiki.diff.js
@@ -3,6 +3,19 @@
$( function () {
var $diffTable = $( 'table.diff[data-mw="interface"]' );
+
+ /**
+ * Fired when the diff is added to a page containing a diff
+ *
+ * Similar to the {@link mw.hook#event-wikipage_content
wikipage.content hook}
+ * $diff may still be detached when the hook is fired.
+ *
+ * @event wikipage_diff
+ * @member mw.hook
+ * @param {jQuery} $diff The root element of the MediaWiki diff
(`table.diff`).
+ */
+ mw.hook( 'wikipage.diff' ).fire( $diffTable.eq( 0 ) );
+
/**
* Fired when the content of the diff displayed on the diff
page changes
*
diff --git a/resources/src/mediawiki/page/startup.js
b/resources/src/mediawiki/page/startup.js
index 282799a..73f5f18 100644
--- a/resources/src/mediawiki/page/startup.js
+++ b/resources/src/mediawiki/page/startup.js
@@ -22,21 +22,6 @@
* root)
*/
mw.hook( 'wikipage.content' ).fire( $( '#mw-content-text' ) );
-
- var $diff = $( 'table.diff[data-mw="interface"]' );
- if ( $diff.length ) {
- /**
- * Fired when the diff is added to a page containing a
diff
- *
- * Similar to the {@link mw.hook#event-wikipage_content
wikipage.content hook}
- * $diff may still be detached when the hook is fired.
- *
- * @event wikipage_diff
- * @member mw.hook
- * @param {jQuery} $diff The root element of the
MediaWiki diff (`table.diff`).
- */
- mw.hook( 'wikipage.diff' ).fire( $diff.eq( 0 ) );
- }
} );
}( mediaWiki, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/308762
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92d6a8fbced64fd44edc394de0969e910e1ddd34
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Fomafix <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
