Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/308767

Change subject: Do not nest mw-content-text element when reloading a diff
......................................................................

Do not nest mw-content-text element when reloading a diff

Bug: T144391
Change-Id: I1ac8c5f31a5e0c34913ba37676f5b3a89aa4db35
(cherry picked from commit a6c5c5a81c451f7019792cd542e53e3000710e20)
---
M modules/ext.RevisionSlider.DiffPage.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider 
refs/changes/67/308767/1

diff --git a/modules/ext.RevisionSlider.DiffPage.js 
b/modules/ext.RevisionSlider.DiffPage.js
index f6656b2..3253c08 100644
--- a/modules/ext.RevisionSlider.DiffPage.js
+++ b/modules/ext.RevisionSlider.DiffPage.js
@@ -59,8 +59,8 @@
                                $catLinks.replaceWith( $data.find( '#catlinks' 
) );
                                $sidePanel.replaceWith( $data.find( '#mw-panel' 
) );
                                $printFooter.replaceWith( $data.find( 
'.printfooter' ) );
-                               $contentText.html( $data.find( 
'#mw-content-text' ) )
-                                       .find( 
'.mw-revslider-revisions-container' ).scrollLeft( scrollLeft );
+                               $contentText.replaceWith( $data.find( 
'#mw-content-text' ) );
+                               $contentText.find( 
'.mw-revslider-revisions-container' ).scrollLeft( scrollLeft );
 
                                mw.hook( 'wikipage.content' ).fire( 
$contentText );
                        }, function ( xhr ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/308767
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ac8c5f31a5e0c34913ba37676f5b3a89aa4db35
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: wmf/1.28.0-wmf.18
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to