jenkins-bot has submitted this change and it was merged.
Change subject: Temporarily trigger revslider.diffreload to re-add Thanks JS
code
......................................................................
Temporarily trigger revslider.diffreload to re-add Thanks JS code
In order to properly fix problems reported in T142636, core hook
triggered on diff change (on diff page) will be added in
I5aad7cc10a0db869d7c25d41f7db056885dad69b.
When that change is merged, Thanks extension will be listening
to this hook and not to RevisionSlider-specific revslider.diffreload.
This adds temporary code fixing RevisionSlider's and Thanks' interaction
before hook introduced in I5aad7cc10a0db869d7c25d41f7db056885dad69b is
available. After it gets merged, the code added here should be replaced
by firing the new core hook.
Change-Id: I5dd6c592165ed30244ac8bff37bb6e4949c8bc4a
(cherry picked from commit 9581a55ba247c31f114689a0a7e79c92ec838343)
---
M modules/ext.RevisionSlider.DiffPage.js
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.RevisionSlider.DiffPage.js
b/modules/ext.RevisionSlider.DiffPage.js
index 70e1515..4ada71a 100644
--- a/modules/ext.RevisionSlider.DiffPage.js
+++ b/modules/ext.RevisionSlider.DiffPage.js
@@ -74,6 +74,11 @@
self.reInitWikEdDiff();
}
+ // Following code is deprecated and will be
removed soon. Revision Slider should
+ // trigger general (core) hook instead of its
own hook. Extensions do not have to
+ // be aware of Revision Slider to interact
properly with it.
+ mw.hook( 'revslider.diffreload' ).fire(
$contentText );
+
}, function ( xhr ) {
$( 'table.diff[data-mw="interface"]'
).removeClass( 'mw-revslider-diff-loading' );
if ( xhr.statusText !== 'abort' ) {
--
To view, visit https://gerrit.wikimedia.org/r/308769
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5dd6c592165ed30244ac8bff37bb6e4949c8bc4a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: wmf/1.28.0-wmf.18
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
