Awight has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308771
Change subject: Fix spelling
......................................................................
Fix spelling
However... this comment might be irrelevant. The code is actually joining 8
random 1-byte integers together (all produced by the same algorithm). We're
clearly attempting to make a number with 64 bits of entropy, and the comment
is quite oblique about that fact.
Change-Id: I59ac0c208bdb9d7f427fea4f205ee7293a710ca8
---
M resources/src/mediawiki/mediawiki.user.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/71/308771/1
diff --git a/resources/src/mediawiki/mediawiki.user.js
b/resources/src/mediawiki/mediawiki.user.js
index 0fdd9aa..7df778f 100644
--- a/resources/src/mediawiki/mediawiki.user.js
+++ b/resources/src/mediawiki/mediawiki.user.js
@@ -76,8 +76,8 @@
hexRnds[ i ] = byteToHex[ rnds[ i ] ];
}
- // Concatenation of two random integers with entrophy n
and m
- // returns a string with entrophy n+m if those strings
are independent
+ // Concatenation of two random integers with entropy n
and m
+ // returns a string with entropy n+m if those strings
are independent
return hexRnds.join( '' );
},
--
To view, visit https://gerrit.wikimedia.org/r/308771
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59ac0c208bdb9d7f427fea4f205ee7293a710ca8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
