Ori.livneh has submitted this change and it was merged. Change subject: Delete space and PHPUnit tests pass! ......................................................................
Delete space and PHPUnit tests pass! A stray space in the API PHP file made whatever test came first fail. So fix it and restore the first test. (The other fails because Jenkins CI doesn't have an Admin account, I left it deleted for now.) Also remove empty setUp, and rename functions checkXxx instead of assertXxx. Change-Id: I11b45af55c292f56e6f880956e73b9a5e967dd11 --- M api/ApiAccountCreation.php M tests/phpunit/api/ApiAccountCreationTest.php 2 files changed, 21 insertions(+), 12 deletions(-) Approvals: Ori.livneh: Verified; Looks good to me, approved Mattflaschen: Looks good to me, but someone else must approve jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/46906 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11b45af55c292f56e6f880956e73b9a5e967dd11 Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/E3Experiments Gerrit-Branch: master Gerrit-Owner: Spage <[email protected]> Gerrit-Reviewer: Mattflaschen <[email protected]> Gerrit-Reviewer: Ori.livneh <[email protected]> Gerrit-Reviewer: Spage <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
