John Erling Blad has uploaded a new change for review. Change subject: Make test providers static ......................................................................
Make test providers static This changeset changes the providers and some additional calls to use what is said to be the preferred form. According to Krinkle the test providers should be static (https://gerrit.wikimedia.org/r/#/c/34524/1/repo/tests/phpunit/includes/FuzzyCompareTest.php) and core has converted to this. That said the test infact work and gives the correct result when the providers are non-static. This is also according to the manual for PHPunit which uses both forms. My opinion is that static is unnecessary by example, but if the change makes people happy, then why not. Change-Id: I1576115caf6d14524289e406df205e6f91b6f8f4 --- M lib/tests/phpunit/TemplateRegistryTest.php M lib/tests/phpunit/TemplateTest.php M lib/tests/phpunit/TermTest.php M lib/tests/phpunit/UtilsTest.php M lib/tests/phpunit/entity/EntityDiffOldTest.php M lib/tests/phpunit/entity/EntityFactoryTest.php M lib/tests/phpunit/item/ItemDiffTest.php M lib/tests/phpunit/item/ItemMultilangTextsTest.php M repo/tests/phpunit/includes/AutocommentTest.php M repo/tests/phpunit/includes/EditEntityTest.php M repo/tests/phpunit/includes/ItemViewTest.php M repo/tests/phpunit/includes/actions/EditEntityActionTest.php M repo/tests/phpunit/includes/api/ApiGetEntitiesTest.php M repo/tests/phpunit/includes/api/ApiLinkTitlesTest.php M repo/tests/phpunit/includes/api/ApiModifyItemBase.php M repo/tests/phpunit/includes/api/ApiSetSiteLinkTest.php 16 files changed, 63 insertions(+), 63 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/70/47370/1 -- To view, visit https://gerrit.wikimedia.org/r/47370 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1576115caf6d14524289e406df205e6f91b6f8f4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: John Erling Blad <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
