jenkins-bot has submitted this change and it was merged. Change subject: Fix typos ......................................................................
Fix typos Change-Id: I49e7e28de3efcb5836e2d99faa357b9f368573b6 --- M LoginNotify.hooks.php M LoginNotify_body.php 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Aude: Looks good to me, approved jenkins-bot: Verified diff --git a/LoginNotify.hooks.php b/LoginNotify.hooks.php index 57b1662..ce1474f 100644 --- a/LoginNotify.hooks.php +++ b/LoginNotify.hooks.php @@ -204,7 +204,7 @@ * * @todo This is a bit icky. Need to decide if we really want to do this. * @todo If someone explicitly enables, gets admin rights, gets de-admined, - * this will then disable the preference, which is defnitely non-ideal. + * this will then disable the preference, which is definitely non-ideal. * @param $user User * @param &$options array * @return bool @@ -241,7 +241,7 @@ /** * Helper for onUser(Load|Save)Options * - * @return Array Which option keys to check + * @return array Which option keys to check */ private static function getOverridenOptions() { // For login-success, it makes most sense to email diff --git a/LoginNotify_body.php b/LoginNotify_body.php index c77569f..436e518 100644 --- a/LoginNotify_body.php +++ b/LoginNotify_body.php @@ -584,7 +584,7 @@ * * @param $key string cache key * @param $max int interval of one to send notice - * @param $expiry When to expire cache key. + * @param $expiry int When to expire cache key. * @return Bool|int false to not send notice, or number of hits */ private function checkAndIncKey( $key, $interval, $expiry ) { -- To view, visit https://gerrit.wikimedia.org/r/309969 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49e7e28de3efcb5836e2d99faa357b9f368573b6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/LoginNotify Gerrit-Branch: master Gerrit-Owner: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Aude <aude.w...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits