Subramanya Sastry has uploaded a new change for review. Change subject: Code cleanup + refactoring in Template Handler. ......................................................................
Code cleanup + refactoring in Template Handler. * Params.dict and Params.named were computing the dictionary each time they were called which is not necessary. Added memoized properties that compute these dicts once per tpl. * Did some code refactoring and cleanup in template handler code in preparation for setting up template params object to be passed to the VE. The template target was not being resolved when the PHP preprocessor was called to expand template transclusions. Updated code to resolve template target always so that the template params object can be set up as per http://www.mediawiki.org/wiki/Parsoid/RDFa_vocabulary#Non-semantic_parameter_editing * No change in parser tests (as it should be for refactoring). Change-Id: I6d5b16413521a1c3359499a2883647ec6b07eeda --- M js/lib/ext.core.TemplateHandler.js M js/lib/mediawiki.parser.defines.js 2 files changed, 173 insertions(+), 143 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid refs/changes/28/47528/1 -- To view, visit https://gerrit.wikimedia.org/r/47528 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6d5b16413521a1c3359499a2883647ec6b07eeda Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
