jenkins-bot has submitted this change and it was merged.
Change subject: Test null listener in CardLargeHeaderViewTest
......................................................................
Test null listener in CardLargeHeaderViewTest
Change-Id: I34d32e4708fc01d1c5627ccb45eee9aa9a646dba
---
M app/src/androidTest/java/org/wikipedia/feed/view/CardLargeHeaderViewTest.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/app/src/androidTest/java/org/wikipedia/feed/view/CardLargeHeaderViewTest.java
b/app/src/androidTest/java/org/wikipedia/feed/view/CardLargeHeaderViewTest.java
index 83123a1..95328fb 100644
---
a/app/src/androidTest/java/org/wikipedia/feed/view/CardLargeHeaderViewTest.java
+++
b/app/src/androidTest/java/org/wikipedia/feed/view/CardLargeHeaderViewTest.java
@@ -5,7 +5,6 @@
import android.support.annotation.StringRes;
import android.view.View;
-import org.junit.Test;
import org.junit.experimental.theories.Theory;
import org.junit.experimental.theories.suppliers.TestedOn;
import org.wikipedia.R;
@@ -64,14 +63,16 @@
assertText(subject, R.id.view_card_header_large_title, text);
}
- @Test public void testOnClickListener() {
+ @Theory public void testOnClickListener(@TestedOn(ints = {0, 1}) int
nonnull) {
setUp(WIDTH_DP_L, LayoutDirection.LOCALE, 1, Theme.LIGHT,
R.drawable.checkerboard,
R.string.reading_list_name_sample);
- OnClickListener listener = mock(View.OnClickListener.class);
+ OnClickListener listener = nonnull == 0 ? null :
mock(View.OnClickListener.class);
subject.onClickListener(listener);
subject.performClick();
- verify(listener);
+ if (listener != null) {
+ verify(listener);
+ }
}
private void setUp(int widthDp, @NonNull LayoutDirection layoutDirection,
float fontScale,
--
To view, visit https://gerrit.wikimedia.org/r/310481
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34d32e4708fc01d1c5627ccb45eee9aa9a646dba
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
