jenkins-bot has submitted this change and it was merged.
Change subject: Special:Nuke: Remove submit button at the top of the form
......................................................................
Special:Nuke: Remove submit button at the top of the form
There's already another submit button at the bottom of the form.
Since this button at the top is very close to the select links
and it is easy to unintentionally click on the submit button
while attempting to click a select link, remove the button at
the top. A submit button at the bottom is also how we normally
have in other forms.
Bug: T145346
Change-Id: If0b21aea8ef8f1762bdafc98527de06f04d59703
---
M Nuke_body.php
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Nuke_body.php b/Nuke_body.php
index a88ca14..bafd758 100644
--- a/Nuke_body.php
+++ b/Nuke_body.php
@@ -190,13 +190,10 @@
);
}
- // Select checkboxes and delete button
$out->addHTML(
$selectLinks .
- Xml::submitButton( $this->msg( 'nuke-submit-delete'
)->text() )
+ '<ul>'
);
-
- $out->addHTML( '<ul>' );
$wordSeparator = $this->msg( 'word-separator' )->escaped();
$commaSeparator = $this->msg( 'comma-separator' )->escaped();
--
To view, visit https://gerrit.wikimedia.org/r/310330
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0b21aea8ef8f1762bdafc98527de06f04d59703
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Nuke
Gerrit-Branch: master
Gerrit-Owner: Glaisher <glaisher.w...@gmail.com>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
