jenkins-bot has submitted this change and it was merged. Change subject: Map should take viewport width/height instead of body width/height ......................................................................
Map should take viewport width/height instead of body width/height Bug: T145521 Change-Id: If164ea9de10f5288899bf9401d0aff9d1ea244de (cherry picked from commit 278a29d9eeadf8b477cb792893dcd32909bce81e) --- M modules/box/Map.js 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Thcipriani: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/box/Map.js b/modules/box/Map.js index 564f8a1..0caf4f4 100644 --- a/modules/box/Map.js +++ b/modules/box/Map.js @@ -8,7 +8,7 @@ * @class Kartographer.Box.MapClass * @extends L.Map */ -module.Map = ( function ( mw, OpenFullScreenControl, CloseFullScreenControl, dataLayerOpts, ScaleControl, topojson, document, undefined ) { +module.Map = ( function ( mw, OpenFullScreenControl, CloseFullScreenControl, dataLayerOpts, ScaleControl, topojson, window, undefined ) { var scale, urlFormat, mapServer = mw.config.get( 'wgKartographerMapServer' ), @@ -779,8 +779,8 @@ if ( this.options.fullscreen ) { this._size = new L.Point( - document.body.clientWidth, - document.body.clientHeight + window.innerWidth, + window.innerHeight ); return; } @@ -886,7 +886,7 @@ module.dataLayerOpts, module.ScaleControl, require( 'ext.kartographer.lib.topojson' ), - document + window ); module.map = ( function ( Map ) { -- To view, visit https://gerrit.wikimedia.org/r/310590 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If164ea9de10f5288899bf9401d0aff9d1ea244de Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Kartographer Gerrit-Branch: wmf/1.28.0-wmf.19 Gerrit-Owner: Yurik <yu...@wikimedia.org> Gerrit-Reviewer: JGirault <julien.inbox.w...@gmail.com> Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com> Gerrit-Reviewer: Thcipriani <tcipri...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits