jenkins-bot has submitted this change and it was merged.
Change subject: repository: implement --dry-run
......................................................................
repository: implement --dry-run
And rename the fixup function to better reflect its focus on the
protocol qualifier.
Change-Id: Ic5a06817be612cdc553be6e8f109ea8f7e6d8781
Signed-off-by: Loic Dachary <l...@dachary.org>
---
M FLOSSbot/main.py
M FLOSSbot/repository.py
2 files changed, 16 insertions(+), 7 deletions(-)
Approvals:
Dachary: Looks good to me, approved
jenkins-bot: Verified
diff --git a/FLOSSbot/main.py b/FLOSSbot/main.py
index 4ad4abe..d1227c8 100644
--- a/FLOSSbot/main.py
+++ b/FLOSSbot/main.py
@@ -43,6 +43,11 @@
default=logging.INFO)
self.parser.add_argument(
+ '--dry-run',
+ action='store_true', default=None,
+ help='no side effect')
+
+ self.parser.add_argument(
'--language-code',
default='wikidata',
choices=['test', 'wikidata'],
diff --git a/FLOSSbot/repository.py b/FLOSSbot/repository.py
index 675f963..0fafbd6 100644
--- a/FLOSSbot/repository.py
+++ b/FLOSSbot/repository.py
@@ -153,11 +153,11 @@
for item in pg.WikidataSPARQLPageGenerator(QUERY,
site=site,
result_type=list):
- self.fixup(site, item)
+ log.info("WORKING ON https://www.wikidata.org/wiki/"; + item.id)
+ self.fixup_protocol(site, item)
- def fixup(self, site, item):
+ def fixup_protocol(self, site, item):
self.setup_cache(site)
- log.info("WORKING ON https://www.wikidata.org/wiki/"; + item.id)
item_dict = item.get()
clm_dict = item_dict["claims"]
@@ -174,11 +174,13 @@
source_code_repository = pywikibot.Claim(
site, P_source_code_repository, 0)
source_code_repository.setTarget(extracted)
- item.addClaim(source_code_repository)
+ if not self.args.dry_run:
+ item.addClaim(source_code_repository)
if claim.getRank() == 'normal':
- claim.changeRank('preferred')
- log.info("PREFERRED " + url + " rank set to preferred")
+ if not self.args.dry_run:
+ claim.changeRank('preferred')
+ log.info("PREFERRED set to " + url)
for claim in clm_dict['P1324']:
Repository.fixup_url(claim)
@@ -195,7 +197,9 @@
raise "error"
protocol = pywikibot.Claim(site, P_protocol, 0)
protocol.setTarget(target_protocol)
- claim.addQualifier(protocol, bot=True)
+ if not self.args.dry_run:
+ claim.addQualifier(protocol, bot=True)
+ log.info("SET protocol of " + claim.getTarget())
@staticmethod
def guess_protocol_from_url(url):
--
To view, visit https://gerrit.wikimedia.org/r/310603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5a06817be612cdc553be6e8f109ea8f7e6d8781
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/bots/FLOSSbot
Gerrit-Branch: master
Gerrit-Owner: Dachary <l...@dachary.org>
Gerrit-Reviewer: Dachary <l...@dachary.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
