jenkins-bot has submitted this change and it was merged.
Change subject: Close HelpDialouge when clicking away from it
......................................................................
Close HelpDialouge when clicking away from it
Bug: T145525
Change-Id: Ia21d5163f561ede4f327eec3a4aaf7c34d103094
---
M modules/ext.RevisionSlider.HelpDialog.js
M modules/ext.RevisionSlider.init.js
2 files changed, 24 insertions(+), 6 deletions(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.RevisionSlider.HelpDialog.js
b/modules/ext.RevisionSlider.HelpDialog.js
index 0c8d168..ee606a8 100644
--- a/modules/ext.RevisionSlider.HelpDialog.js
+++ b/modules/ext.RevisionSlider.HelpDialog.js
@@ -162,15 +162,31 @@
} );
/**
- * Shows the help dialog
+ * Initializes the help dialog
*/
- HelpDialog.show = function () {
+ HelpDialog.init = function () {
var windowManager = new OO.ui.WindowManager(),
- dialogue = new HelpDialog( { size: 'medium', classes: [
'revisionslider-help-dialog' ] } );
+ dialogue;
- $( 'body' ).append( windowManager.$element );
- windowManager.addWindows( [ dialogue ] );
- windowManager.openWindow( dialogue );
+ $( 'body' )
+ .append( windowManager.$element )
+ .click( function ( event ) {
+ if ( $( event.target ).hasClass(
'revisionslider-help-dialog' ) ) {
+ HelpDialog.hide();
+ }
+ } );
+
+ HelpDialog.show = function () {
+ dialogue = new HelpDialog( { size: 'medium', classes: [
'revisionslider-help-dialog' ] } );
+ windowManager.addWindows( [ dialogue ] );
+ windowManager.openWindow( dialogue );
+ };
+
+ HelpDialog.hide = function () {
+ if ( windowManager.hasWindow( dialogue ) ) {
+ windowManager.closeWindow( dialogue );
+ }
+ };
};
mw.libs.revisionSlider = mw.libs.revisionSlider || {};
diff --git a/modules/ext.RevisionSlider.init.js
b/modules/ext.RevisionSlider.init.js
index 371fb0d..8e1144f 100644
--- a/modules/ext.RevisionSlider.init.js
+++ b/modules/ext.RevisionSlider.init.js
@@ -15,6 +15,8 @@
mw.track( 'counter.MediaWiki.RevisionSlider.event.init'
);
mw.libs.revisionSlider.userOffset =
mw.user.options.values.timecorrection ?
mw.user.options.values.timecorrection.split( '|' )[ 1 ] :
mw.config.values.extRevisionSliderTimeOffset;
+ mw.libs.revisionSlider.HelpDialog.init();
+
api.fetchRevisionData( mw.config.get( 'wgPageName' ), {
startId:
mw.config.values.extRevisionSliderNewRev,
limit:
mw.libs.revisionSlider.calculateRevisionsPerWindow( 160, 16 )
--
To view, visit https://gerrit.wikimedia.org/r/310747
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia21d5163f561ede4f327eec3a4aaf7c34d103094
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
