Alexandros Kosiaris has submitted this change and it was merged.

Change subject: postgres: Allow replication user to connect to all databases
......................................................................


postgres: Allow replication user to connect to all databases

A replication connection has special characteristics and never really
connects to a database so even specifying that "replication" as the
database the user can connect to is not required. However monitoring
scripts DO regular connections and do need that. So just allow the
replication user to connect to all databases. That is not lowering
security since a replication user can anyway just replicate away the
entire database

Change-Id: Ib6ed10a5b9a71716d71aa0261cecc76b3d3846bd
---
M hieradata/common/puppetmaster/puppetdb.yaml
M modules/role/manifests/osm/master.pp
M modules/role/manifests/postgres/master.pp
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Alexandros Kosiaris: Verified; Looks good to me, approved



diff --git a/hieradata/common/puppetmaster/puppetdb.yaml 
b/hieradata/common/puppetmaster/puppetdb.yaml
index 7c82677..2c64fd1 100644
--- a/hieradata/common/puppetmaster/puppetdb.yaml
+++ b/hieradata/common/puppetmaster/puppetdb.yaml
@@ -1,7 +1,7 @@
 postgres_users:
   replication@nihal-v4:
     user: replication
-    database: replication
+    database: all
     password: "%{::puppetmaster::puppetdb::database::replication_pass}"
     cidr: 10.192.16.184/32
     pgversion: 9.4
diff --git a/modules/role/manifests/osm/master.pp 
b/modules/role/manifests/osm/master.pp
index 2350b0b..ebcee84 100644
--- a/modules/role/manifests/osm/master.pp
+++ b/modules/role/manifests/osm/master.pp
@@ -79,7 +79,7 @@
             type     => 'host',
             method   => 'md5',
             attrs    => 'REPLICATION',
-            database => 'replication',
+            database => 'all',
         }
     }
 
diff --git a/modules/role/manifests/postgres/master.pp 
b/modules/role/manifests/postgres/master.pp
index 8d68678..c2ca83c 100644
--- a/modules/role/manifests/postgres/master.pp
+++ b/modules/role/manifests/postgres/master.pp
@@ -31,7 +31,7 @@
             type     => 'host',
             method   => 'md5',
             attrs    => 'REPLICATION',
-            database => 'replication',
+            database => 'all',
         }
     }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/310797
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6ed10a5b9a71716d71aa0261cecc76b3d3846bd
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <akosia...@wikimedia.org>
Gerrit-Reviewer: Alexandros Kosiaris <akosia...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to