jenkins-bot has submitted this change and it was merged. Change subject: Add one more level for GlobalTitleFail logging ......................................................................
Add one more level for GlobalTitleFail logging htmlspecialchars/Message->__toString/Message->toString/Message->parseText/MessageCache->parse is useless without the caller of htmlspecialchars(). Change-Id: I2dad5a487225a11b98149610f1c775057f8baad2 --- M includes/cache/MessageCache.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/cache/MessageCache.php b/includes/cache/MessageCache.php index d254d3d..e871855 100644 --- a/includes/cache/MessageCache.php +++ b/includes/cache/MessageCache.php @@ -1089,7 +1089,7 @@ if ( !$title || !$title instanceof Title ) { global $wgTitle; wfDebugLog( 'GlobalTitleFail', __METHOD__ . ' called by ' . - wfGetAllCallers( 5 ) . ' with no title set.' ); + wfGetAllCallers( 6 ) . ' with no title set.' ); $title = $wgTitle; } // Sometimes $wgTitle isn't set either... -- To view, visit https://gerrit.wikimedia.org/r/311052 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dad5a487225a11b98149610f1c775057f8baad2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits