Elukey has submitted this change and it was merged.

Change subject: Add a directive to mod_proxy_html's yarn configuration
......................................................................


Add a directive to mod_proxy_html's yarn configuration

Sadly a lot of a hrefs to replace in the yarn proxied content
are embedded in inline JS. This will slow down a bit the overall
rendering time but it will improve the user experience.

Bug: T116192
Change-Id: I90a66f1fbbce76b5f539d149398a4efdd36fdc65
---
M modules/statistics/templates/yarn.wikimedia.org.erb
1 file changed, 9 insertions(+), 3 deletions(-)

Approvals:
  Elukey: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/statistics/templates/yarn.wikimedia.org.erb 
b/modules/statistics/templates/yarn.wikimedia.org.erb
index 043b1a1..0f14d7a 100644
--- a/modules/statistics/templates/yarn.wikimedia.org.erb
+++ b/modules/statistics/templates/yarn.wikimedia.org.erb
@@ -31,9 +31,15 @@
         # The Jetty Webserver (responsible for the Yarn UI) returns HTML with 
hardcoded
         # links in the HTML hrefs, so we need a way to avoid broken links.
         ProxyHTMLEnable On
+        # ProxyHTMLExtended forces mod_proxy_html to parse CSS/JS files too
+        # causing performance penalties in the overall rendering time.
+        # Unfortunately this is needed since some analytics1001 links are
+        # contained in embedded JS script that cause a broken UI experience
+        # if left untouched.
+        ProxyHTMLExtended On
         ProxyHTMLLinks a href
-        ProxyHTMLURLMap http://analytics1001.eqiad.wmnet:8088/ / Lecn
-        ProxyHTMLURLMap http://analytics1001.eqiad.wmnet:19888/ / Lecn
+        ProxyHTMLURLMap http://analytics1001.eqiad.wmnet:8088/ / L
+        ProxyHTMLURLMap http://analytics1001.eqiad.wmnet:19888/ / L
     </Location>
 
     CustomLog /var/log/apache2/yarn.wikimedia.org-access.log wmf
@@ -46,4 +52,4 @@
 
     ProxyPass / http://analytics1001.eqiad.wmnet:8088/
     ProxyPassReverse / http://analytics1001.eqiad.wmnet:8088/
-</VirtualHost>
\ No newline at end of file
+</VirtualHost>

-- 
To view, visit https://gerrit.wikimedia.org/r/310863
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I90a66f1fbbce76b5f539d149398a4efdd36fdc65
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Elukey <ltosc...@wikimedia.org>
Gerrit-Reviewer: Elukey <ltosc...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to