Filippo Giunchedi has submitted this change and it was merged.

Change subject: monitoring: validate check_prometheus args
......................................................................


monitoring: validate check_prometheus args

Change-Id: I9338a627d07c7d5d80914b3c06b2f081c6ee9598
---
M modules/monitoring/manifests/check_prometheus.pp
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Filippo Giunchedi: Looks good to me, approved
  Volans: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/modules/monitoring/manifests/check_prometheus.pp 
b/modules/monitoring/manifests/check_prometheus.pp
index 3a53842..968dd29 100644
--- a/modules/monitoring/manifests/check_prometheus.pp
+++ b/modules/monitoring/manifests/check_prometheus.pp
@@ -84,6 +84,9 @@
     $contact_group   = 'admins'
 )
 {
+    validate_re($method, '^(gt|ge|lt|le|eq|ne)$')
+    validate_bool($nan_ok)
+
     $command = $nan_ok ? {
         true    => 'check_prometheus_nan_ok',
         default => 'check_prometheus',

-- 
To view, visit https://gerrit.wikimedia.org/r/310835
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9338a627d07c7d5d80914b3c06b2f081c6ee9598
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: Volans <rcocci...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to