jenkins-bot has submitted this change and it was merged.

Change subject: Improve timing of hiding link preview when loading a new page.
......................................................................


Improve timing of hiding link preview when loading a new page.

Bug: T145697
Change-Id: I5ec56fd991b0bb1ac61bd6149d8c61752cab1ad6
---
M app/src/main/java/org/wikipedia/page/PageActivity.java
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Niedzielski: Looks good to me, approved



diff --git a/app/src/main/java/org/wikipedia/page/PageActivity.java 
b/app/src/main/java/org/wikipedia/page/PageActivity.java
index b23d321..f2ee4a1 100644
--- a/app/src/main/java/org/wikipedia/page/PageActivity.java
+++ b/app/src/main/java/org/wikipedia/page/PageActivity.java
@@ -361,9 +361,6 @@
             new LinkPreviewFunnel(app, entry.getSource()).logNavigate();
         }
 
-        // Close the link preview, if one is open.
-        hideLinkPreview();
-
         app.putCrashReportProperty("api", title.getSite().authority());
         app.putCrashReportProperty("title", title.toString());
 
@@ -378,6 +375,8 @@
                 if (!pageFragment.isAdded()) {
                     return;
                 }
+                // Close the link preview, if one is open.
+                hideLinkPreview();
                 //is the new title the same as what's already being displayed?
                 if (position == TabPosition.CURRENT_TAB
                         && 
!pageFragment.getCurrentTab().getBackStack().isEmpty()

-- 
To view, visit https://gerrit.wikimedia.org/r/311135
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5ec56fd991b0bb1ac61bd6149d8c61752cab1ad6
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to