Milimetric has submitted this change and it was merged.

Change subject: Disable the deprecated option by_wiki

Disable the deprecated option by_wiki

The previous patch adds a new way of exploding reports with files.
After deploying the previous patch, all repositories that use
exploding by wiki should be updated to use the new way.
And finally, this patch can be merged.

Bug: T132481
Change-Id: Icd2fc80095e1fdebaa0cc04525a77491b8053af0
M reportupdater/
M reportupdater/
M reportupdater/
D wikis.txt
5 files changed, 2 insertions(+), 876 deletions(-)

  Milimetric: Looks good to me, approved
  jenkins-bot: Verified

diff --git a/reportupdater/ b/reportupdater/
index 0a0d408..b2dc891 100644
--- a/reportupdater/
+++ b/reportupdater/
@@ -14,7 +14,7 @@
 import logging
 from datetime import datetime, date
 from report import Report
-from utils import DATE_FORMAT, raise_critical, get_wikis
+from utils import DATE_FORMAT, raise_critical
 class Reader(object):
@@ -146,8 +146,6 @@
     def get_explode_by(self, report_config, query_folder):
         explode_by = {}
-        if 'by_wiki' in report_config and report_config['by_wiki'] is True:
-            explode_by['wiki'] = get_wikis(self.config) + ['all']
         if 'explode_by' in report_config:
             for placeholder, values_str in 
                 values = [value.strip() for value in values_str.split(',')]
@@ -158,7 +156,7 @@
                             read_values = [v.strip() for v in 
                         if (len(read_values) > 0):
                             explode_by[placeholder] = read_values
-                    except IOError, e:
+                    except IOError:
                         explode_by[placeholder] = values
                 elif len(values) > 1:
                     explode_by[placeholder] = values
diff --git a/reportupdater/ b/reportupdater/
index 8ed5183..e11863c 100644
--- a/reportupdater/
+++ b/reportupdater/
@@ -42,7 +42,6 @@
         config['current_exec_time'] = current_exec_time
         config['query_folder'] = params['query_folder']
         config['output_folder'] = params['output_folder']
-        config['wikis_path'] = params['wikis_path']
         reader = Reader(config)
         selector = Selector(reader, config)
@@ -63,7 +62,6 @@
         'pid_file_path': os.path.join(query_folder, ''),
         'config_path': os.path.join(query_folder, 'config.yaml'),
         'output_folder': os.path.join(project_root, 'output'),
-        'wikis_path': os.path.join(project_root, 'wikis.txt'),
         'log_level': logging.WARNING
     passed_params = {k: v for k, v in passed_params.iteritems() if v is not 
diff --git a/reportupdater/ b/reportupdater/
index 032a74a..d894717 100644
--- a/reportupdater/
+++ b/reportupdater/
@@ -64,20 +64,6 @@
     return previous_results
-def get_wikis(config):
-    if 'wikis_path' not in config:
-        raise_critical(KeyError, 'Wikis path is not in config.')
-    try:
-        wikis_file =['wikis_path'], 'r')
-    except Exception, e:
-        raise_critical(RuntimeError, 'Could not open the wikis file (' + 
str(e) + ').')
-    wikis = []
-    for wiki in wikis_file:
-        wikis.append(wiki.strip())
-    wikis_file.close()
-    return wikis
 def get_exploded_report_output_path(output_folder, explode_by, report_key):
     output_folder = os.path.join(output_folder, report_key)
     placeholders = sorted(explode_by.keys())
diff --git a/ b/
index 20dd7a1..45e33c5 100755
--- a/
+++ b/
@@ -24,8 +24,6 @@
                         help='Folder to write the TSV files to.')
                         help='Yaml configuration file. Default: 
-    parser.add_argument('--wikis_path',
-                        help='All wikis list file path. Default: wikis.txt.')
     parser.add_argument('-l', '--log-level',
     args = vars(parser.parse_args())
diff --git a/wikis.txt b/wikis.txt
deleted file mode 100644
index d2c30cc..0000000
--- a/wikis.txt
+++ /dev/null
@@ -1,854 +0,0 @@

To view, visit
To unsubscribe, visit

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd2fc80095e1fdebaa0cc04525a77491b8053af0
Gerrit-PatchSet: 4
Gerrit-Project: analytics/reportupdater
Gerrit-Branch: master
Gerrit-Owner: Mforns <>
Gerrit-Reviewer: Mforns <>
Gerrit-Reviewer: Milimetric <>
Gerrit-Reviewer: jenkins-bot <>

MediaWiki-commits mailing list

Reply via email to