jenkins-bot has submitted this change and it was merged.

Change subject: Hygiene: set initial container visibility in XML
......................................................................


Hygiene: set initial container visibility in XML

Change-Id: I22dbdbd73d6b129a3f3415e8901a8aa7bd930d03
---
M app/src/main/java/org/wikipedia/search/SearchFragment.java
M app/src/main/res/layout/fragment_search.xml
2 files changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Dbrant: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/app/src/main/java/org/wikipedia/search/SearchFragment.java 
b/app/src/main/java/org/wikipedia/search/SearchFragment.java
index ed2e58d..818d771 100644
--- a/app/src/main/java/org/wikipedia/search/SearchFragment.java
+++ b/app/src/main/java/org/wikipedia/search/SearchFragment.java
@@ -140,9 +140,6 @@
         searchResultsFragment = 
(SearchResultsFragment)childFragmentManager.findFragmentById(
                 R.id.fragment_search_results);
 
-        // make sure we're hidden by default
-        searchContainer.setVisibility(View.GONE);
-
         if (savedInstanceState != null) {
             lastSearchedText = 
savedInstanceState.getString(ARG_LAST_SEARCHED_TEXT);
             invokeSource = 
SearchInvokeSource.of(savedInstanceState.getInt(ARG_INVOKE_SOURCE));
diff --git a/app/src/main/res/layout/fragment_search.xml 
b/app/src/main/res/layout/fragment_search.xml
index 89db238..13f6e80 100644
--- a/app/src/main/res/layout/fragment_search.xml
+++ b/app/src/main/res/layout/fragment_search.xml
@@ -6,7 +6,9 @@
     android:id="@+id/search_container"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
-    android:orientation="vertical">
+    android:visibility="gone"
+    android:orientation="vertical"
+    tools:visibility="visible">
 
     <org.wikipedia.views.StatusBarBlankView
         android:id="@+id/empty_status_bar"

-- 
To view, visit https://gerrit.wikimedia.org/r/310970
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I22dbdbd73d6b129a3f3415e8901a8aa7bd930d03
Gerrit-PatchSet: 4
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to