jenkins-bot has submitted this change and it was merged.

Change subject: Re-add removed option check to jquery.wikibase.edittoolbar.js
......................................................................


Re-add removed option check to jquery.wikibase.edittoolbar.js

Change-Id: Ic3483b81f7376c34323a0571390ead4918a06881
---
M view/resources/jquery/wikibase/toolbar/jquery.wikibase.edittoolbar.js
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Hoo man: Looks good to me, approved
  Jonas Kress (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/view/resources/jquery/wikibase/toolbar/jquery.wikibase.edittoolbar.js 
b/view/resources/jquery/wikibase/toolbar/jquery.wikibase.edittoolbar.js
index 3c733ce..d455a87 100644
--- a/view/resources/jquery/wikibase/toolbar/jquery.wikibase.edittoolbar.js
+++ b/view/resources/jquery/wikibase/toolbar/jquery.wikibase.edittoolbar.js
@@ -88,6 +88,10 @@
        _create: function() {
                PARENT.prototype._create.call( this );
 
+               if ( !this.options.getHelpMessage ) {
+                       throw new Error( 'Required option not specified 
properly' );
+               }
+
                this._buttons = {};
 
                var $scrapedSubToolbar = this.getContainer().children( 
'.wikibase-toolbar' );

-- 
To view, visit https://gerrit.wikimedia.org/r/299712
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3483b81f7376c34323a0571390ead4918a06881
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo M├Ąttig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to