jenkins-bot has submitted this change and it was merged.

Change subject: i18n: Make the OK button label translateable

i18n: Make the OK button label translateable

Change-Id: Idb7cb249b582f0bf15f1ea6ec1d0aece5c9efdc5
M i18n/en.json
M i18n/qqq.json
M includes/CookieWarning.hooks.php
3 files changed, 5 insertions(+), 3 deletions(-)

  Florianschmidtwelzow: Looks good to me, approved
  jenkins-bot: Verified

diff --git a/i18n/en.json b/i18n/en.json
index 90aade8..f5bb8f3 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -7,5 +7,6 @@
        "cookiewarning-info": "Cookies help us deliver our services. By using 
our services, you agree to our use of cookies.",
        "cookiewarning-desc": "Provides a notice at the top of the page about 
        "cookiewarning-moreinfo-label": "More information",
-       "cookiewarning-more-link": "-"
+       "cookiewarning-more-link": "-",
+       "cookiewarning-ok-label": "OK"
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 5130213..e01533e 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -7,5 +7,6 @@
        "cookiewarning-info": "Information message for visitors of the wiki, 
informing them that this wiki uses cookies.",
        "cookiewarning-moreinfo-label": "Label for the \"More information\" 
link in the cookiewarning information bar.",
-       "cookiewarning-more-link": "{{notranslate}}\nUsed as an on-wiki way to 
edit the target of the more information link."
+       "cookiewarning-more-link": "{{notranslate}}\nUsed as an on-wiki way to 
edit the target of the more information link.",
+       "cookiewarning-ok-label": "The label for the \"OK\" button in the 
cookiewarning information bar."
diff --git a/includes/CookieWarning.hooks.php b/includes/CookieWarning.hooks.php
index 8e4758c..8171bfd 100644
--- a/includes/CookieWarning.hooks.php
+++ b/includes/CookieWarning.hooks.php
@@ -73,7 +73,7 @@
                        $moreLink .
                        Html::openElement( 'form', array( 'method' => 'POST' ) 
) .
-                               'OK',
+                               $sk->msg( 'cookiewarning-ok-label' )->text(),
                                        'name' => 'disablecookiewarning',
                                        'class' => 'mw-cookiewarning-dismiss'

To view, visit
To unsubscribe, visit

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb7cb249b582f0bf15f1ea6ec1d0aece5c9efdc5
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CookieWarning
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <>
Gerrit-Reviewer: Florianschmidtwelzow <>
Gerrit-Reviewer: Siebrand <>
Gerrit-Reviewer: jenkins-bot <>

MediaWiki-commits mailing list

Reply via email to