jenkins-bot has submitted this change and it was merged.

Change subject: Adjust the HTML output of the ArticlePlaceholder structure
......................................................................


Adjust the HTML output of the ArticlePlaceholder structure

In order to make the placeholders are semantically well structured, removed 
unnecessary classes and div/p tag.

Bug: T144589
Change-Id: I802ba44dcac1c1cf775fadbd4ec2cd646a8ff74b
---
M includes/Lua/mw/ext/articlePlaceholder/statementRenderer.lua
M 
modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css
2 files changed, 1 insertion(+), 10 deletions(-)

Approvals:
  Hoo man: Looks good to me, approved
  Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/includes/Lua/mw/ext/articlePlaceholder/statementRenderer.lua 
b/includes/Lua/mw/ext/articlePlaceholder/statementRenderer.lua
index ee7c6ba..018245f 100644
--- a/includes/Lua/mw/ext/articlePlaceholder/statementRenderer.lua
+++ b/includes/Lua/mw/ext/articlePlaceholder/statementRenderer.lua
@@ -30,7 +30,7 @@
       end
     end
   end
-  return result .. '<div class="articleplaceholder-statement"><p><span 
class="articleplaceholder-value">' .. mainsnak .. '</span>' .. reference .. 
'</p></div>' .. qualifier
+  return result .. '<div class="articleplaceholder-statement">' .. mainsnak .. 
reference .. qualifier .. '</div>'
 end
 
 -- Get a function which is bound to the given entityrenderer.
diff --git 
a/modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css
 
b/modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css
index 2205ecb..38dd701 100644
--- 
a/modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css
+++ 
b/modules/ext.articleplaceholder.defaultDisplay/ext.articleplaceholder.defaultDisplay.css
@@ -59,15 +59,6 @@
   margin-top: 1.5em;
 }
 
-.articleplaceholder-identifierlist .articleplaceholder-value {
-  font-size: 100%;
-}
-
-.articleplaceholder-identifierlist .articleplaceholder-value {
-  font-size: 100%;
-  margin-left: 1.5em;
-}
-
 .articleplaceholder-qualifier {
   margin-left: 1em;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/309954
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I802ba44dcac1c1cf775fadbd4ec2cd646a8ff74b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Lucie Kaffee <lucie.kaf...@wikimedia.de>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Jackmcbarn <jackmcb...@gmail.com>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to