BBlack has submitted this change and it was merged.

Change subject: cache_upload: FE size limit 1MB
......................................................................


cache_upload: FE size limit 1MB

512KB didn't offer notable improvement over 1MB, and 2MB seems to
have slightly dropped FE hitrate, so 1MB seems reasonably-optimal
for now.

Change-Id: Id748ebd4a513867b1306c41b8712753e14da02eb
---
M modules/varnish/templates/upload-frontend.inc.vcl.erb
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  BBlack: Verified; Looks good to me, approved



diff --git a/modules/varnish/templates/upload-frontend.inc.vcl.erb 
b/modules/varnish/templates/upload-frontend.inc.vcl.erb
index e99764f..2ced015 100644
--- a/modules/varnish/templates/upload-frontend.inc.vcl.erb
+++ b/modules/varnish/templates/upload-frontend.inc.vcl.erb
@@ -77,8 +77,8 @@
        }
        <%- end -%>
 
-       // hit-for-pass objects >= 2MB size
-       if (std.integer(beresp.http.Content-Length, 2097152) >= 2097152 || 
beresp.http.Content-Length ~ "^[0-9]{9}") {
+       // hit-for-pass objects >= 1MB size
+       if (std.integer(beresp.http.Content-Length, 1048576) >= 1048576 || 
beresp.http.Content-Length ~ "^[0-9]{9}") {
                set beresp.http.X-CDIS = "pass";
                <%- if @varnish_version4 -%>
                set beresp.uncacheable = true;

-- 
To view, visit https://gerrit.wikimedia.org/r/311336
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id748ebd4a513867b1306c41b8712753e14da02eb
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <bbl...@wikimedia.org>
Gerrit-Reviewer: BBlack <bbl...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to