Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311355

Change subject: ce.MWTransclusionNode: Clean up href normalization
......................................................................

ce.MWTransclusionNode: Clean up href normalization

This became a special case when decodeURIComponentIntoArticleTitle()
was introduced, presumably because we skipped underscore transformation
out of laziness here. It doesn't matter whether we do underscore normalization
because we do title normalization right after, so make this code
less exceptional by using the fully decoded title.

Change-Id: I036cc7f1e08895d36224c94b8edc3ad700af1947
---
M modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/55/311355/1

diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js 
b/modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
index cef9f69..9654097 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
@@ -201,7 +201,7 @@
                                var targetData = 
ve.dm.MWInternalLinkAnnotation.static.getTargetDataFromHref(
                                                this.href, 
transclusionNode.getModelHtmlDocument()
                                        ),
-                                       normalisedHref = 
ve.decodeURIComponentIntoArticleTitle( targetData.rawTitle, false );
+                                       normalisedHref = targetData.title;
                                if ( mw.Title.newFromText( normalisedHref ) ) {
                                        normalisedHref = mw.Title.newFromText( 
normalisedHref ).getPrefixedText();
                                }

-- 
To view, visit https://gerrit.wikimedia.org/r/311355
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I036cc7f1e08895d36224c94b8edc3ad700af1947
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to