jenkins-bot has submitted this change and it was merged.
Change subject: RedisJobService: prefix log messages with their level
......................................................................
RedisJobService: prefix log messages with their level
When looking at the service log file, it is quite helpful to have the
level mentionned in the message. Add DEBUG, NOTICE, ERROR where
relevant.
Change-Id: I79f749e9789d8561f7d8328b1d5996a228bdd0af
---
M src/RedisJobService.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/RedisJobService.php b/src/RedisJobService.php
index ff43d85..f479a32 100755
--- a/src/RedisJobService.php
+++ b/src/RedisJobService.php
@@ -404,7 +404,7 @@
*/
public function debug( $s ) {
if ( $this->verbose ) {
- print date( DATE_ISO8601 ) . ": $s\n";
+ print date( DATE_ISO8601 ) . " DEBUG: $s\n";
}
}
@@ -412,14 +412,14 @@
* @param string $s
*/
public function notice( $s ) {
- print date( DATE_ISO8601 ) . ": $s\n";
+ print date( DATE_ISO8601 ) . " NOTICE: $s\n";
}
/**
* @param string $s
*/
public function error( $s ) {
- fwrite( STDERR, date( DATE_ISO8601 ) . ": $s\n" );
+ fwrite( STDERR, date( DATE_ISO8601 ) . " ERROR: $s\n" );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/311388
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79f749e9789d8561f7d8328b1d5996a228bdd0af
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/jobrunner
Gerrit-Branch: master
Gerrit-Owner: Hashar <has...@free.fr>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
