jenkins-bot has submitted this change and it was merged.

Change subject: Give a text label to the Feed overflow menu button.
......................................................................


Give a text label to the Feed overflow menu button.

Because our "custom" overflow button uses @null as its title, it can lead
to some unexpected behavior. For example, in the rare case when this
button is forced to overflow into the "real" overflow menu provided by
Android, the resulting menu item appears empty.

This patch simply provides a text label for the custom overflow button, so
that if it overflows "for real", it will at least have a label.

Bug: T145911
Change-Id: If5bf1c3b4918dd29af1ebd146b156bc704d0732b
---
M app/src/main/res/menu/menu_feed.xml
M app/src/main/res/values-qq/strings.xml
M app/src/main/res/values/strings.xml
3 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Niedzielski: Looks good to me, approved



diff --git a/app/src/main/res/menu/menu_feed.xml 
b/app/src/main/res/menu/menu_feed.xml
index 2cabd05..8900889 100644
--- a/app/src/main/res/menu/menu_feed.xml
+++ b/app/src/main/res/menu/menu_feed.xml
@@ -10,7 +10,7 @@
         android:title="@string/menu_page_show_tabs"
         app:showAsAction="ifRoom"/>
     <item android:id="@+id/menu_overflow_button"
-        android:title="@null"
+        android:title="@string/menu_feed_overflow_label"
         android:icon="@drawable/ic_more_vert_white_24dp"
         app:showAsAction="ifRoom"/>
 </menu>
diff --git a/app/src/main/res/values-qq/strings.xml 
b/app/src/main/res/values-qq/strings.xml
index d78bf1c..ce57ed1 100644
--- a/app/src/main/res/values-qq/strings.xml
+++ b/app/src/main/res/values-qq/strings.xml
@@ -384,6 +384,7 @@
   <string name="menu_feed_card_dismiss">Menu item used for hiding a certain 
item in the list of feed cards.</string>
   <string name="menu_feed_card_dismissed">Message to inform the user that the 
selected item has been hidden.</string>
   <string name="feed_featured_image_share_subject">Text included as the 
subject when a user shares an image from the Today\'s Featured Image feed 
card.</string>
+  <string name="menu_feed_overflow_label">Label for toolbar menu item that 
shows the user more options, such as logging in and accessing the app 
settings.</string>
   <string name="feed">Menu item label for exploring Wikipedia content through 
Feed cards.
 {{Identical|Explore}}</string>
   <string name="view_card_footer_button">Feed card button label for requesting 
more similar cards.</string>
diff --git a/app/src/main/res/values/strings.xml 
b/app/src/main/res/values/strings.xml
index c545333..9e21e10 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -311,6 +311,7 @@
     <string name="view_featured_image_card_download">Download</string>
     <string name="menu_feed_card_dismiss">Hide this card</string>
     <string name="menu_feed_card_dismissed">Card hidden.</string>
+    <string name="menu_feed_overflow_label">More options</string>
 
     <string name="feed_featured_image_share_subject">Featured image from 
Wikimedia Commons</string>
     <string name="feed">Explore</string>

-- 
To view, visit https://gerrit.wikimedia.org/r/311413
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If5bf1c3b4918dd29af1ebd146b156bc704d0732b
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to