jenkins-bot has submitted this change and it was merged. Change subject: Avoid deprecated LBFactory::singleton() in tests ......................................................................
Avoid deprecated LBFactory::singleton() in tests Change-Id: Ic6dadd663826cfe95593c9b85ee06e22ac5ffbfb (cherry picked from commit 818172ac471787cbdbad78d986e5f6b917adb48e) --- M client/includes/Hooks/ChangesListSpecialPageHookHandlers.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified diff --git a/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php b/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php index ab0a78d..776b1fc 100644 --- a/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php +++ b/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php @@ -6,7 +6,7 @@ use FormOptions; use IContextSource; use LoadBalancer; -use LBFactory; +use MediaWiki\MediaWikiServices; use RequestContext; use User; use WebRequest; @@ -90,7 +90,7 @@ return new self( $context->getRequest(), $context->getUser(), - LBFactory::singleton()->getMainLB(), + MediaWikiServices::getInstance()->getDBLoadBalancer(), $specialPageName, $settings->getSetting( 'showExternalRecentChanges' ) ); -- To view, visit https://gerrit.wikimedia.org/r/311442 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6dadd663826cfe95593c9b85ee06e22ac5ffbfb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: wmf/1.28.0-wmf.18 Gerrit-Owner: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits