Bearloga has submitted this change and it was merged.

Change subject: Margin bug fix
......................................................................


Margin bug fix

ggplot2 fivethirtynine theme margin bug discovered and fixed by Oliver
Keyes (https://github.com/wikimedia/wikimedia-discovery-wmf/pull/1)

Change-Id: Ib77c033620fa02bd0544c1ee97097d818a4a1704
---
M DESCRIPTION
M NEWS.md
M R/dataviz.R
3 files changed, 11 insertions(+), 7 deletions(-)

Approvals:
  Bearloga: Verified; Looks good to me, approved



diff --git a/DESCRIPTION b/DESCRIPTION
index 264dd67..eca1a54 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -1,13 +1,13 @@
 Package: wmf
 Type: Package
 Title: R Code for Wikimedia Foundation Internal Usage
-Version: 0.2.2
-Date: 2016-08-25
+Version: 0.2.3
+Date: 2016-09-19
 Authors@R: c(
   person("Oliver", "Keyes", email = "oli...@wikimedia.org", role = "cre"),
   person("Mikhail", "Popov", email = "mpo...@wikimedia.org", role = "aut"))
 Description: More about what it does (maybe more than one line).
-License: What license is it under?
+License: Uhhhhh
 LazyData: TRUE
 Imports:
     RMySQL,
diff --git a/NEWS.md b/NEWS.md
index d7ac98d..ec4646a 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,3 +1,7 @@
+wmf 0.2.3
+=============
+Fixes ggplot2 theme margin bug [discovered & 
fixed](https://github.com/wikimedia/wikimedia-discovery-wmf/pull/1) by Oliver 
Keyes.
+
 wmf 0.2.2
 =============
 * Updates `query_hive()` to support [JAR path 
overriding](https://wikitech.wikimedia.org/wiki/Analytics/Cluster/Hive/QueryUsingUDF#Testing_changes_to_existing_udf)
diff --git a/R/dataviz.R b/R/dataviz.R
index 4773b0b..e52d156 100644
--- a/R/dataviz.R
+++ b/R/dataviz.R
@@ -20,8 +20,8 @@
      theme(line = element_line(), rect = element_rect(fill = 
ggthemes:::ggthemes_data$fivethirtyeight["ltgray"],
                                                       linetype = 0, colour = 
NA),
            text = element_text(colour = 
ggthemes:::ggthemes_data$fivethirtyeight["dkgray"], margin = ggplot2::margin(), 
debug = FALSE),
-           axis.title.y = element_text(size = rel(2), angle = 90, vjust = 1.5, 
margin = ggplot2::margin(12), debug = FALSE),
-           axis.text = element_text(size=rel(1.5)),
+           axis.title.y = element_text(size = rel(2), angle = 90, vjust = 1.5, 
margin = ggplot2::margin(0, 12), debug = FALSE),
+           axis.text = element_text(size = rel(1.5)),
            axis.title.x = element_text(size = rel(2), margin = 
ggplot2::margin(12), debug = FALSE),
            axis.ticks = element_blank(), axis.line = element_blank(),
            legend.background = element_rect(), legend.position = "bottom",
@@ -31,8 +31,8 @@
            panel.grid.minor = element_blank(),
            plot.title = element_text(hjust = 0, size = rel(1.5), face = 
"bold", margin = ggplot2::margin(), debug = FALSE),
            strip.background = element_rect(),
-           legend.text = element_text(size=18), legend.title = 
element_text(size=rel(1.5), margin = ggplot2::margin(4), debug = FALSE),
-           legend.key.size = unit(1,"in"),
+           legend.text = element_text(size = 18), legend.title = 
element_text(size = rel(1.5), margin = ggplot2::margin(4), debug = FALSE),
+           legend.key.size = unit(1, "in"),
            panel.background = element_rect(fill = "transparent", color = NA),
            plot.background = element_rect(fill = "transparent", color = NA)))
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/311456
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib77c033620fa02bd0544c1ee97097d818a4a1704
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/discovery/wmf
Gerrit-Branch: master
Gerrit-Owner: Bearloga <mpo...@wikimedia.org>
Gerrit-Reviewer: Bearloga <mpo...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to