Dbrant has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311467

Change subject: Fix custom overflow button when it's shown from the real 
overflow menu.
......................................................................

Fix custom overflow button when it's shown from the real overflow menu.

Change-Id: Iaec085445e2f840a90704f2a42a0b9c4f26f95cd
---
M app/src/main/java/org/wikipedia/feed/FeedFragment.java
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/67/311467/1

diff --git a/app/src/main/java/org/wikipedia/feed/FeedFragment.java 
b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
index 3195a70..29ba9b3 100644
--- a/app/src/main/java/org/wikipedia/feed/FeedFragment.java
+++ b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
@@ -181,9 +181,7 @@
                     return false;
                 }
                 View overflowButton = callback.getOverflowMenuButton();
-                if (overflowButton != null) {
-                    showOverflowMenu(overflowButton);
-                }
+                showOverflowMenu(overflowButton == null ? feedView : 
overflowButton);
                 return true;
             default:
                 return super.onOptionsItemSelected(item);

-- 
To view, visit https://gerrit.wikimedia.org/r/311467
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaec085445e2f840a90704f2a42a0b9c4f26f95cd
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to