jenkins-bot has submitted this change and it was merged.

Change subject: MediaWiki theme: Fix SelectFileWidget's label visibility in IE11
......................................................................


MediaWiki theme: Fix SelectFileWidget's label visibility in IE11

After the MIME type information is gone, we can handle this issue
differently and let filename `span` act as block element, ensuring both -
label visibility in IE11 and ellipsis as text-overflow on long
filenames

Bug: T127267
Change-Id: I7603de235bab47572d4167d260cf0b13ce7ebc35
---
M src/themes/mediawiki/widgets.less
1 file changed, 9 insertions(+), 4 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/themes/mediawiki/widgets.less 
b/src/themes/mediawiki/widgets.less
index 80d3a92..5ea8a5c 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -242,12 +242,17 @@
                .oo-ui-box-sizing( border-box );
                display: block;
                right: @size-icon + 0.5em; // With close, no indicator
-               line-height: 2.3;
                margin: 0;
-               overflow: hidden;
-               white-space: nowrap;
-               text-overflow: ellipsis;
                padding-left: 0.5em;
+               line-height: 2.3;
+               white-space: nowrap;
+       }
+
+       // Addressing overflowing (long) filenames
+       &-fileName {
+               display: block;
+               overflow: hidden;
+               text-overflow: ellipsis;
        }
 
        &-clearButton {

-- 
To view, visit https://gerrit.wikimedia.org/r/311060
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7603de235bab47572d4167d260cf0b13ce7ebc35
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: Anomie <bjor...@wikimedia.org>
Gerrit-Reviewer: Bartosz DziewoƄski <matma....@gmail.com>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to