jenkins-bot has submitted this change and it was merged.

Change subject: Remove strictIPs(), cascadingDeletes(), and cleanupTriggers()
......................................................................


Remove strictIPs(), cascadingDeletes(), and cleanupTriggers()

These DatabaseBase methods have no callers are were a mistake to
begin with. They only encouraged code forking and incompatibilities
among different backing DB types.

Also removed stray realTimestamps() method that was left over
from prior removals.

Change-Id: I37bef8585151e2782d2c88b5ae1e6752109c6ac7
---
M includes/db/DatabaseMssql.php
M includes/db/DatabaseOracle.php
M includes/db/DatabasePostgres.php
M includes/libs/rdbms/database/DatabaseBase.php
4 files changed, 2 insertions(+), 61 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/db/DatabaseMssql.php b/includes/db/DatabaseMssql.php
index 2c6db10..00fb800 100644
--- a/includes/db/DatabaseMssql.php
+++ b/includes/db/DatabaseMssql.php
@@ -42,18 +42,6 @@
 
        protected $mPort;
 
-       public function cascadingDeletes() {
-               return true;
-       }
-
-       public function cleanupTriggers() {
-               return false;
-       }
-
-       public function realTimestamps() {
-               return false;
-       }
-
        public function implicitGroupby() {
                return false;
        }
diff --git a/includes/db/DatabaseOracle.php b/includes/db/DatabaseOracle.php
index ee1bf65..561dadb 100644
--- a/includes/db/DatabaseOracle.php
+++ b/includes/db/DatabaseOracle.php
@@ -176,18 +176,6 @@
                return 'oracle';
        }
 
-       function cascadingDeletes() {
-               return true;
-       }
-
-       function cleanupTriggers() {
-               return true;
-       }
-
-       function strictIPs() {
-               return true;
-       }
-
        function implicitGroupby() {
                return false;
        }
diff --git a/includes/db/DatabasePostgres.php b/includes/db/DatabasePostgres.php
index e5ce283..1907bab 100644
--- a/includes/db/DatabasePostgres.php
+++ b/includes/db/DatabasePostgres.php
@@ -227,18 +227,6 @@
                return 'postgres';
        }
 
-       function cascadingDeletes() {
-               return true;
-       }
-
-       function cleanupTriggers() {
-               return true;
-       }
-
-       function strictIPs() {
-               return true;
-       }
-
        function implicitGroupby() {
                return false;
        }
diff --git a/includes/libs/rdbms/database/DatabaseBase.php 
b/includes/libs/rdbms/database/DatabaseBase.php
index 2c8d239..ef72998 100644
--- a/includes/libs/rdbms/database/DatabaseBase.php
+++ b/includes/libs/rdbms/database/DatabaseBase.php
@@ -49,32 +49,9 @@
        }
 
        /**
-        * Returns true if this database supports (and uses) cascading deletes
+        * Get search engine class. All subclasses of this need to implement 
this
+        * if they wish to use searching.
         *
-        * @return bool
-        */
-       public function cascadingDeletes() {
-               return false;
-       }
-       /**
-        * Returns true if this database supports (and uses) triggers (e.g. on 
the page table)
-        *
-        * @return bool
-        */
-       public function cleanupTriggers() {
-               return false;
-       }
-       /**
-        * Returns true if this database is strict about what can be put into 
an IP field.
-        * Specifically, it uses a NULL value instead of an empty string.
-        *
-        * @return bool
-        */
-       public function strictIPs() {
-               return false;
-       }
-
-       /**
         * @return string
         * @deprecated since 1.27; use 
SearchEngineFactory::getSearchEngineClass()
         */

-- 
To view, visit https://gerrit.wikimedia.org/r/311091
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I37bef8585151e2782d2c88b5ae1e6752109c6ac7
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Parent5446 <tylerro...@gmail.com>
Gerrit-Reviewer: Skizzerz <skizz...@skizzerz.net>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to