Andrew Bogott has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311618

Change subject: Puppet Panel:  Remove the ?-in-circle
......................................................................

Puppet Panel:  Remove the ?-in-circle

This is nice when it works, but most browsers cannot
render that icon.  After this patch, docs will appear as
hover text over the puppet role name.

Change-Id: Ic7c7bee8aab7832aaa42d9a6b083a43e28cd90a7
---
M modules/openstack/files/liberty/horizon/puppettab/puppet_roles.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/18/311618/1

diff --git a/modules/openstack/files/liberty/horizon/puppettab/puppet_roles.py 
b/modules/openstack/files/liberty/horizon/puppettab/puppet_roles.py
index 69bf466..0283b58 100644
--- a/modules/openstack/files/liberty/horizon/puppettab/puppet_roles.py
+++ b/modules/openstack/files/liberty/horizon/puppettab/puppet_roles.py
@@ -113,11 +113,11 @@
                 obj.docs = newdoc
 
             simplename = obj.name.split('role::')[1]
-            html = '%s <span title="%s" class="fa-question-circle" />' % (
-                escape(simplename),
-                escape(obj.docs)
-            )
             obj.html_name = mark_safe(html)
+            html = '<span title="%s">%s</>' % (
+                escape(obj.docs),
+                escape(simplename)
+            )
 
             roles.append(obj)
 

-- 
To view, visit https://gerrit.wikimedia.org/r/311618
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7c7bee8aab7832aaa42d9a6b083a43e28cd90a7
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott <abog...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to