BBlack has submitted this change and it was merged. Change subject: upload frontend: limit at 256KB ......................................................................
upload frontend: limit at 256KB more ongoing experimentation. 1MB seems to work pretty decently. I've tried 512KB before, but reverted after seeing very little effect. I may not have waited long enough to see it, though. Also, recent data analysis for the backends indicates 256K might be a much better value here anyways. Change-Id: I378525339347361286ef2a5187fb7912244dcd54 --- M modules/varnish/templates/upload-frontend.inc.vcl.erb 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: BBlack: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/varnish/templates/upload-frontend.inc.vcl.erb b/modules/varnish/templates/upload-frontend.inc.vcl.erb index 8e4e2c9..f9cac18 100644 --- a/modules/varnish/templates/upload-frontend.inc.vcl.erb +++ b/modules/varnish/templates/upload-frontend.inc.vcl.erb @@ -98,8 +98,8 @@ <%- end -%> } - // hit-for-pass objects >= 1MB size - if (std.integer(beresp.http.Content-Length, 1048576) >= 1048576 || beresp.http.Content-Length ~ "^[0-9]{9}") { + // hit-for-pass objects >= 256K size + if (std.integer(beresp.http.Content-Length, 262144) >= 262144 || beresp.http.Content-Length ~ "^[0-9]{9}") { set beresp.http.X-CDIS = "pass"; <%- if @varnish_version4 -%> set beresp.uncacheable = true; -- To view, visit https://gerrit.wikimedia.org/r/311619 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I378525339347361286ef2a5187fb7912244dcd54 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: BBlack <bbl...@wikimedia.org> Gerrit-Reviewer: BBlack <bbl...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits