jenkins-bot has submitted this change and it was merged.

Change subject: Move entity usage from basic to properties section in 
action=info
......................................................................


Move entity usage from basic to properties section in action=info

Change-Id: I28f0b0cf1bc0fd01ec938bd81db926148618ed3e
---
M client/includes/Hooks/InfoActionHookHandler.php
M client/tests/phpunit/includes/Hooks/InfoActionHookHandlerTest.php
2 files changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Aude: Looks good to me, approved
  Ladsgroup: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/client/includes/Hooks/InfoActionHookHandler.php 
b/client/includes/Hooks/InfoActionHookHandler.php
index d5880ad..db662aa 100644
--- a/client/includes/Hooks/InfoActionHookHandler.php
+++ b/client/includes/Hooks/InfoActionHookHandler.php
@@ -70,7 +70,7 @@
                }
 
                if ( $usage ) {
-                       $pageInfo['header-basic'][] = $this->formatEntityUsage( 
$context, $usage );
+                       $pageInfo['header-properties'][] = 
$this->formatEntityUsage( $context, $usage );
                }
 
                return $pageInfo;
diff --git a/client/tests/phpunit/includes/Hooks/InfoActionHookHandlerTest.php 
b/client/tests/phpunit/includes/Hooks/InfoActionHookHandlerTest.php
index b5728fb..a8f0cee 100644
--- a/client/tests/phpunit/includes/Hooks/InfoActionHookHandlerTest.php
+++ b/client/tests/phpunit/includes/Hooks/InfoActionHookHandlerTest.php
@@ -47,6 +47,8 @@
                                                $context->msg( 
'wikibase-pageinfo-entity-id' )->escaped(),
                                                
'https://www.wikidata.org/wiki/Q4'
                                        ),
+                               ),
+                               'header-properties' => array(
                                        array(
                                                $context->msg( 
'wikibase-pageinfo-entity-usage' )->escaped(),
                                                
"<ul><li>https://www.wikidata.org/wiki/Q4</li><ul><li>Sitelink</li></ul></ul>",
@@ -58,7 +60,7 @@
                );
 
                $cases[] = array(
-                       array( 'header-basic' => array(
+                       array( 'header-properties' => array(
                                        array(
                                                $context->msg( 
'wikibase-pageinfo-entity-usage' )->escaped(),
                                                
"<ul><li>https://www.wikidata.org/wiki/Q4</li><ul><li>Sitelink</li></ul></ul>",
@@ -66,7 +68,7 @@
                                )
                        ),
                        $context,
-                       array( 'header-basic' => array() ),
+                       array( 'header-properties' => array() ),
                        false,
                        new ItemId( 'Q4' ),
                        'namespace does not have wikibase enabled'

-- 
To view, visit https://gerrit.wikimedia.org/r/311328
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I28f0b0cf1bc0fd01ec938bd81db926148618ed3e
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Thiemo M├Ąttig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to